Commit 9887b5e5 authored by Sabitha George's avatar Sabitha George Committed by Greg Kroah-Hartman

staging: ks7010: Fix warnings on printk() usage

This patch fixes the following warnings on ks7010_sdio.c
1. printk() should include KERN_ facility level
2. Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
Signed-off-by: default avatarSabitha George <sabitha.george@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 03806ab3
...@@ -496,7 +496,9 @@ static void ks7010_rw_function(struct work_struct *work) ...@@ -496,7 +496,9 @@ static void ks7010_rw_function(struct work_struct *work)
DPRINTK(4, "wait after WAKEUP\n"); DPRINTK(4, "wait after WAKEUP\n");
/* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq, /* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
(priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/ (priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/
printk("wake: %lu %lu\n", priv->last_wakeup + (30 * HZ) / 1000, dev_info(&priv->ks_wlan_hw.sdio_card->func->dev,
"wake: %lu %lu\n",
priv->last_wakeup + (30 * HZ) / 1000,
jiffies); jiffies);
msleep(30); msleep(30);
} }
...@@ -1003,11 +1005,12 @@ static int ks7010_sdio_probe(struct sdio_func *func, ...@@ -1003,11 +1005,12 @@ static int ks7010_sdio_probe(struct sdio_func *func,
/* private memory allocate */ /* private memory allocate */
netdev = alloc_etherdev(sizeof(*priv)); netdev = alloc_etherdev(sizeof(*priv));
if (!netdev) { if (!netdev) {
printk(KERN_ERR "ks7010 : Unable to alloc new net device\n"); dev_err(&card->func->dev, "ks7010 : Unable to alloc new net device\n");
goto error_release_irq; goto error_release_irq;
} }
if (dev_alloc_name(netdev, "wlan%d") < 0) { if (dev_alloc_name(netdev, "wlan%d") < 0) {
printk(KERN_ERR "ks7010 : Couldn't get name!\n"); dev_err(&card->func->dev,
"ks7010 : Couldn't get name!\n");
goto error_free_netdev; goto error_free_netdev;
} }
...@@ -1047,8 +1050,8 @@ static int ks7010_sdio_probe(struct sdio_func *func, ...@@ -1047,8 +1050,8 @@ static int ks7010_sdio_probe(struct sdio_func *func,
/* Upload firmware */ /* Upload firmware */
ret = ks7010_upload_firmware(priv, card); /* firmware load */ ret = ks7010_upload_firmware(priv, card); /* firmware load */
if (ret) { if (ret) {
printk(KERN_ERR dev_err(&card->func->dev,
"ks7010: firmware load failed !! retern code = %d\n", "ks7010: firmware load failed !! return code = %d\n",
ret); ret);
goto error_free_read_buf; goto error_free_read_buf;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment