Commit 989e4da0 authored by Sumera Priyadarsini's avatar Sumera Priyadarsini Committed by David S. Miller

net: gianfar: Add of_node_put() before goto statement

Every iteration of for_each_available_child_of_node() decrements
reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in gianfar.c by inserting of_node_put()
before the goto statement.

Issue found with Coccinelle.
Signed-off-by: default avatarSumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5680790b
...@@ -750,9 +750,11 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev) ...@@ -750,9 +750,11 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
continue; continue;
err = gfar_parse_group(child, priv, model); err = gfar_parse_group(child, priv, model);
if (err) if (err) {
of_node_put(child);
goto err_grp_init; goto err_grp_init;
} }
}
} else { /* SQ_SG_MODE */ } else { /* SQ_SG_MODE */
err = gfar_parse_group(np, priv, model); err = gfar_parse_group(np, priv, model);
if (err) if (err)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment