Commit 9a1e9693 authored by Mathieu Desnoyers's avatar Mathieu Desnoyers Committed by Ingo Molnar

tracepoints: fix reentrancy

The tracepoints had the same problem markers did have wrt reentrancy. Apply a
similar fix using a rcu_barrier after each tracepoint mutex lock.
Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent ca2db6cf
...@@ -356,6 +356,8 @@ int tracepoint_probe_register(const char *name, void *probe) ...@@ -356,6 +356,8 @@ int tracepoint_probe_register(const char *name, void *probe)
mutex_lock(&tracepoints_mutex); mutex_lock(&tracepoints_mutex);
entry = get_tracepoint(name); entry = get_tracepoint(name);
WARN_ON(!entry); WARN_ON(!entry);
if (entry->rcu_pending)
rcu_barrier_sched();
tracepoint_entry_free_old(entry, old); tracepoint_entry_free_old(entry, old);
end: end:
mutex_unlock(&tracepoints_mutex); mutex_unlock(&tracepoints_mutex);
...@@ -392,6 +394,8 @@ int tracepoint_probe_unregister(const char *name, void *probe) ...@@ -392,6 +394,8 @@ int tracepoint_probe_unregister(const char *name, void *probe)
entry = get_tracepoint(name); entry = get_tracepoint(name);
if (!entry) if (!entry)
goto end; goto end;
if (entry->rcu_pending)
rcu_barrier_sched();
tracepoint_entry_free_old(entry, old); tracepoint_entry_free_old(entry, old);
remove_tracepoint(name); /* Ignore busy error message */ remove_tracepoint(name); /* Ignore busy error message */
ret = 0; ret = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment