Commit 9aad7329 authored by Jani Nikula's avatar Jani Nikula

drm/i915: move display_irqs_enabled to display substruct

The info is related to display, and should be placed under
i915->display.
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/f6ac8e4c6ec8621bacf3db58a2bf156bd636f1d1.1712599670.git.jani.nikula@intel.com
parent 53e8de10
...@@ -448,6 +448,8 @@ struct intel_display { ...@@ -448,6 +448,8 @@ struct intel_display {
} ips; } ips;
struct { struct {
bool display_irqs_enabled;
/* For i915gm/i945gm vblank irq workaround */ /* For i915gm/i945gm vblank irq workaround */
u8 vblank_enabled; u8 vblank_enabled;
} irq; } irq;
......
...@@ -412,7 +412,7 @@ void i9xx_pipestat_irq_ack(struct drm_i915_private *dev_priv, ...@@ -412,7 +412,7 @@ void i9xx_pipestat_irq_ack(struct drm_i915_private *dev_priv,
spin_lock(&dev_priv->irq_lock); spin_lock(&dev_priv->irq_lock);
if (!dev_priv->display_irqs_enabled) { if (!dev_priv->display.irq.display_irqs_enabled) {
spin_unlock(&dev_priv->irq_lock); spin_unlock(&dev_priv->irq_lock);
return; return;
} }
...@@ -1558,10 +1558,10 @@ void valleyview_enable_display_irqs(struct drm_i915_private *dev_priv) ...@@ -1558,10 +1558,10 @@ void valleyview_enable_display_irqs(struct drm_i915_private *dev_priv)
{ {
lockdep_assert_held(&dev_priv->irq_lock); lockdep_assert_held(&dev_priv->irq_lock);
if (dev_priv->display_irqs_enabled) if (dev_priv->display.irq.display_irqs_enabled)
return; return;
dev_priv->display_irqs_enabled = true; dev_priv->display.irq.display_irqs_enabled = true;
if (intel_irqs_enabled(dev_priv)) { if (intel_irqs_enabled(dev_priv)) {
vlv_display_irq_reset(dev_priv); vlv_display_irq_reset(dev_priv);
...@@ -1573,10 +1573,10 @@ void valleyview_disable_display_irqs(struct drm_i915_private *dev_priv) ...@@ -1573,10 +1573,10 @@ void valleyview_disable_display_irqs(struct drm_i915_private *dev_priv)
{ {
lockdep_assert_held(&dev_priv->irq_lock); lockdep_assert_held(&dev_priv->irq_lock);
if (!dev_priv->display_irqs_enabled) if (!dev_priv->display.irq.display_irqs_enabled)
return; return;
dev_priv->display_irqs_enabled = false; dev_priv->display.irq.display_irqs_enabled = false;
if (intel_irqs_enabled(dev_priv)) if (intel_irqs_enabled(dev_priv))
vlv_display_irq_reset(dev_priv); vlv_display_irq_reset(dev_priv);
...@@ -1770,9 +1770,9 @@ void intel_display_irq_init(struct drm_i915_private *i915) ...@@ -1770,9 +1770,9 @@ void intel_display_irq_init(struct drm_i915_private *i915)
* domain. We defer setting up the display irqs in this case to the * domain. We defer setting up the display irqs in this case to the
* runtime pm. * runtime pm.
*/ */
i915->display_irqs_enabled = true; i915->display.irq.display_irqs_enabled = true;
if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)) if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915))
i915->display_irqs_enabled = false; i915->display.irq.display_irqs_enabled = false;
intel_hotplug_irq_init(i915); intel_hotplug_irq_init(i915);
} }
...@@ -1444,7 +1444,7 @@ void intel_hpd_enable_detection(struct intel_encoder *encoder) ...@@ -1444,7 +1444,7 @@ void intel_hpd_enable_detection(struct intel_encoder *encoder)
void intel_hpd_irq_setup(struct drm_i915_private *i915) void intel_hpd_irq_setup(struct drm_i915_private *i915)
{ {
if (i915->display_irqs_enabled && i915->display.funcs.hotplug) if (i915->display.irq.display_irqs_enabled && i915->display.funcs.hotplug)
i915->display.funcs.hotplug->hpd_irq_setup(i915); i915->display.funcs.hotplug->hpd_irq_setup(i915);
} }
......
...@@ -235,8 +235,6 @@ struct drm_i915_private { ...@@ -235,8 +235,6 @@ struct drm_i915_private {
/* protects the irq masks */ /* protects the irq masks */
spinlock_t irq_lock; spinlock_t irq_lock;
bool display_irqs_enabled;
/* Sideband mailbox protection */ /* Sideband mailbox protection */
struct mutex sb_lock; struct mutex sb_lock;
struct pm_qos_request sb_qos; struct pm_qos_request sb_qos;
......
...@@ -702,7 +702,7 @@ static void valleyview_irq_reset(struct drm_i915_private *dev_priv) ...@@ -702,7 +702,7 @@ static void valleyview_irq_reset(struct drm_i915_private *dev_priv)
gen5_gt_irq_reset(to_gt(dev_priv)); gen5_gt_irq_reset(to_gt(dev_priv));
spin_lock_irq(&dev_priv->irq_lock); spin_lock_irq(&dev_priv->irq_lock);
if (dev_priv->display_irqs_enabled) if (dev_priv->display.irq.display_irqs_enabled)
vlv_display_irq_reset(dev_priv); vlv_display_irq_reset(dev_priv);
spin_unlock_irq(&dev_priv->irq_lock); spin_unlock_irq(&dev_priv->irq_lock);
} }
...@@ -767,7 +767,7 @@ static void cherryview_irq_reset(struct drm_i915_private *dev_priv) ...@@ -767,7 +767,7 @@ static void cherryview_irq_reset(struct drm_i915_private *dev_priv)
GEN3_IRQ_RESET(uncore, GEN8_PCU_); GEN3_IRQ_RESET(uncore, GEN8_PCU_);
spin_lock_irq(&dev_priv->irq_lock); spin_lock_irq(&dev_priv->irq_lock);
if (dev_priv->display_irqs_enabled) if (dev_priv->display.irq.display_irqs_enabled)
vlv_display_irq_reset(dev_priv); vlv_display_irq_reset(dev_priv);
spin_unlock_irq(&dev_priv->irq_lock); spin_unlock_irq(&dev_priv->irq_lock);
} }
...@@ -784,7 +784,7 @@ static void valleyview_irq_postinstall(struct drm_i915_private *dev_priv) ...@@ -784,7 +784,7 @@ static void valleyview_irq_postinstall(struct drm_i915_private *dev_priv)
gen5_gt_irq_postinstall(to_gt(dev_priv)); gen5_gt_irq_postinstall(to_gt(dev_priv));
spin_lock_irq(&dev_priv->irq_lock); spin_lock_irq(&dev_priv->irq_lock);
if (dev_priv->display_irqs_enabled) if (dev_priv->display.irq.display_irqs_enabled)
vlv_display_irq_postinstall(dev_priv); vlv_display_irq_postinstall(dev_priv);
spin_unlock_irq(&dev_priv->irq_lock); spin_unlock_irq(&dev_priv->irq_lock);
...@@ -838,7 +838,7 @@ static void cherryview_irq_postinstall(struct drm_i915_private *dev_priv) ...@@ -838,7 +838,7 @@ static void cherryview_irq_postinstall(struct drm_i915_private *dev_priv)
gen8_gt_irq_postinstall(to_gt(dev_priv)); gen8_gt_irq_postinstall(to_gt(dev_priv));
spin_lock_irq(&dev_priv->irq_lock); spin_lock_irq(&dev_priv->irq_lock);
if (dev_priv->display_irqs_enabled) if (dev_priv->display.irq.display_irqs_enabled)
vlv_display_irq_postinstall(dev_priv); vlv_display_irq_postinstall(dev_priv);
spin_unlock_irq(&dev_priv->irq_lock); spin_unlock_irq(&dev_priv->irq_lock);
......
...@@ -504,7 +504,6 @@ struct xe_device { ...@@ -504,7 +504,6 @@ struct xe_device {
}; };
u32 pipestat_irq_mask[I915_MAX_PIPES]; u32 pipestat_irq_mask[I915_MAX_PIPES];
bool display_irqs_enabled;
u32 enabled_irq_mask; u32 enabled_irq_mask;
struct intel_uncore { struct intel_uncore {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment