Skip to content

L
linux
Commit 9b443c76 authored by Florian Westphal's avatar Florian Westphal Committed by Jakub Kicinski
Browse files
Options

selftests: netfilter: nft_fib.sh: shellcheck cleanups 

no functional change intended.
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Link: https://lore.kernel.org/r/20240418152744.15105-10-fw@strlen.deSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 05af10a8
Show whitespace changes
Inline Side-by-side
Showing with 61 additions and 67 deletions
tools/testing/selftests/net/netfilter/nft_fib.sh
View file @ 9b443c76
...@@ -16,7 +16,7 @@ cleanup() ...@@ -16,7 +16,7 @@ cleanup()
{ {
cleanup_all_ns cleanup_all_ns
[ $log_netns -eq 0 ] && sysctl -q net.netfilter.nf_log_all_netns=$log_netns [ "$log_netns" -eq 0 ] && sysctl -q net.netfilter.nf_log_all_netns=$log_netns
} }
checktool "nft --version" "run test without nft" checktool "nft --version" "run test without nft"
...@@ -25,8 +25,7 @@ setup_ns nsrouter ns1 ns2 ...@@ -25,8 +25,7 @@ setup_ns nsrouter ns1 ns2
trap cleanup EXIT trap cleanup EXIT
dmesg | grep -q ' nft_rpfilter: ' if dmesg | grep -q ' nft_rpfilter: ';then
if [ $? -eq 0 ]; then
dmesg -c | grep ' nft_rpfilter: ' dmesg -c | grep ' nft_rpfilter: '
echo "WARN: a previous test run has failed" 1>&2 echo "WARN: a previous test run has failed" 1>&2
fi fi
...@@ -36,7 +35,7 @@ sysctl -q net.netfilter.nf_log_all_netns=1 ...@@ -36,7 +35,7 @@ sysctl -q net.netfilter.nf_log_all_netns=1
load_ruleset() { load_ruleset() {
local netns=$1 local netns=$1
ip netns exec ${netns} nft -f /dev/stdin <<EOF ip netns exec "$netns" nft -f /dev/stdin <<EOF
table inet filter { table inet filter {
chain prerouting { chain prerouting {
type filter hook prerouting priority 0; policy accept; type filter hook prerouting priority 0; policy accept;
...@@ -49,7 +48,7 @@ EOF ...@@ -49,7 +48,7 @@ EOF
load_pbr_ruleset() { load_pbr_ruleset() {
local netns=$1 local netns=$1
ip netns exec ${netns} nft -f /dev/stdin <<EOF ip netns exec "$netns" nft -f /dev/stdin <<EOF
table inet filter { table inet filter {
chain forward { chain forward {
type filter hook forward priority raw; type filter hook forward priority raw;
...@@ -63,7 +62,7 @@ EOF ...@@ -63,7 +62,7 @@ EOF
load_ruleset_count() { load_ruleset_count() {
local netns=$1 local netns=$1
ip netns exec ${netns} nft -f /dev/stdin <<EOF ip netns exec "$netns" nft -f /dev/stdin <<EOF
table inet filter { table inet filter {
chain prerouting { chain prerouting {
type filter hook prerouting priority 0; policy accept; type filter hook prerouting priority 0; policy accept;
...@@ -89,52 +88,49 @@ check_fib_counter() { ...@@ -89,52 +88,49 @@ check_fib_counter() {
local ns=$2 local ns=$2
local address=$3 local address=$3
line=$(ip netns exec ${ns} nft list table inet filter | grep 'fib saddr . iif' | grep $address | grep "packets $want" ) if ! ip netns exec "$ns" nft list table inet filter | grep 'fib saddr . iif' | grep "$address" | grep -q "packets $want";then
ret=$?
if [ $ret -ne 0 ];then
echo "Netns $ns fib counter doesn't match expected packet count of $want for $address" 1>&2 echo "Netns $ns fib counter doesn't match expected packet count of $want for $address" 1>&2
ip netns exec ${ns} nft list table inet filter ip netns exec "$ns" nft list table inet filter
return 1 return 1
fi fi
if [ $want -gt 0 ]; then if [ "$want" -gt 0 ]; then
echo "PASS: fib expression did drop packets for $address" echo "PASS: fib expression did drop packets for $address"
fi fi
return 0 return 0
} }
load_ruleset ${nsrouter} load_ruleset "$nsrouter"
load_ruleset ${ns1} load_ruleset "$ns1"
load_ruleset ${ns2} load_ruleset "$ns2"
if ! ip link add veth0 netns "$nsrouter" type veth peer name eth0 netns "$ns1" > /dev/null 2>&1; then if ! ip link add veth0 netns "$nsrouter" type veth peer name eth0 netns "$ns1" > /dev/null 2>&1; then
echo "SKIP: No virtual ethernet pair device support in kernel" echo "SKIP: No virtual ethernet pair device support in kernel"
exit $ksft_skip exit $ksft_skip
fi fi
ip link add veth1 netns ${nsrouter} type veth peer name eth0 netns ${ns2} ip link add veth1 netns "$nsrouter" type veth peer name eth0 netns "$ns2"
ip -net ${nsrouter} link set veth0 up ip -net "$nsrouter" link set veth0 up
ip -net ${nsrouter} addr add 10.0.1.1/24 dev veth0 ip -net "$nsrouter" addr add 10.0.1.1/24 dev veth0
ip -net ${nsrouter} addr add dead:1::1/64 dev veth0 nodad ip -net "$nsrouter" addr add dead:1::1/64 dev veth0 nodad
ip -net ${nsrouter} link set veth1 up ip -net "$nsrouter" link set veth1 up
ip -net ${nsrouter} addr add 10.0.2.1/24 dev veth1 ip -net "$nsrouter" addr add 10.0.2.1/24 dev veth1
ip -net ${nsrouter} addr add dead:2::1/64 dev veth1 nodad ip -net "$nsrouter" addr add dead:2::1/64 dev veth1 nodad
ip -net ${ns1} link set eth0 up ip -net "$ns1" link set eth0 up
ip -net ${ns2} link set eth0 up ip -net "$ns2" link set eth0 up
ip -net ${ns1} addr add 10.0.1.99/24 dev eth0 ip -net "$ns1" addr add 10.0.1.99/24 dev eth0
ip -net ${ns1} addr add dead:1::99/64 dev eth0 nodad ip -net "$ns1" addr add dead:1::99/64 dev eth0 nodad
ip -net ${ns1} route add default via 10.0.1.1 ip -net "$ns1" route add default via 10.0.1.1
ip -net ${ns1} route add default via dead:1::1 ip -net "$ns1" route add default via dead:1::1
ip -net ${ns2} addr add 10.0.2.99/24 dev eth0 ip -net "$ns2" addr add 10.0.2.99/24 dev eth0
ip -net ${ns2} addr add dead:2::99/64 dev eth0 nodad ip -net "$ns2" addr add dead:2::99/64 dev eth0 nodad
ip -net ${ns2} route add default via 10.0.2.1 ip -net "$ns2" route add default via 10.0.2.1
ip -net ${ns2} route add default via dead:2::1 ip -net "$ns2" route add default via dead:2::1
test_ping() { test_ping() {
local daddr4=$1 local daddr4=$1
...@@ -155,11 +151,11 @@ test_ping() { ...@@ -155,11 +151,11 @@ test_ping() {
return 0 return 0
} }
ip netns exec ${nsrouter} sysctl net.ipv6.conf.all.forwarding=1 > /dev/null ip netns exec "$nsrouter" sysctl net.ipv6.conf.all.forwarding=1 > /dev/null
ip netns exec ${nsrouter} sysctl net.ipv4.conf.veth0.forwarding=1 > /dev/null ip netns exec "$nsrouter" sysctl net.ipv4.conf.veth0.forwarding=1 > /dev/null
ip netns exec ${nsrouter} sysctl net.ipv4.conf.veth1.forwarding=1 > /dev/null ip netns exec "$nsrouter" sysctl net.ipv4.conf.veth1.forwarding=1 > /dev/null
ip netns exec ${nsrouter} sysctl net.ipv4.conf.all.rp_filter=0 > /dev/null ip netns exec "$nsrouter" sysctl net.ipv4.conf.all.rp_filter=0 > /dev/null
ip netns exec ${nsrouter} sysctl net.ipv4.conf.veth0.rp_filter=0 > /dev/null ip netns exec "$nsrouter" sysctl net.ipv4.conf.veth0.rp_filter=0 > /dev/null
test_ping 10.0.2.1 dead:2::1 || exit 1 test_ping 10.0.2.1 dead:2::1 || exit 1
check_drops || exit 1 check_drops || exit 1
...@@ -169,69 +165,67 @@ check_drops || exit 1 ...@@ -169,69 +165,67 @@ check_drops || exit 1
echo "PASS: fib expression did not cause unwanted packet drops" echo "PASS: fib expression did not cause unwanted packet drops"
ip netns exec ${nsrouter} nft flush table inet filter ip netns exec "$nsrouter" nft flush table inet filter
ip -net ${ns1} route del default ip -net "$ns1" route del default
ip -net ${ns1} -6 route del default ip -net "$ns1" -6 route del default
ip -net ${ns1} addr del 10.0.1.99/24 dev eth0 ip -net "$ns1" addr del 10.0.1.99/24 dev eth0
ip -net ${ns1} addr del dead:1::99/64 dev eth0 ip -net "$ns1" addr del dead:1::99/64 dev eth0
ip -net ${ns1} addr add 10.0.2.99/24 dev eth0 ip -net "$ns1" addr add 10.0.2.99/24 dev eth0
ip -net "$ns1" addr add dead:2::99/64 dev eth0 nodad ip -net "$ns1" addr add dead:2::99/64 dev eth0 nodad
ip -net ${ns1} route add default via 10.0.2.1 ip -net "$ns1" route add default via 10.0.2.1
ip -net ${ns1} -6 route add default via dead:2::1 ip -net "$ns1" -6 route add default via dead:2::1
ip -net "$nsrouter" addr add dead:2::1/64 dev veth0 nodad ip -net "$nsrouter" addr add dead:2::1/64 dev veth0 nodad
# switch to ruleset that doesn't log, this time # switch to ruleset that doesn't log, this time
# its expected that this does drop the packets. # its expected that this does drop the packets.
load_ruleset_count ${nsrouter} load_ruleset_count "$nsrouter"
# ns1 has a default route, but nsrouter does not. # ns1 has a default route, but nsrouter does not.
# must not check return value, ping to 1.1.1.1 will # must not check return value, ping to 1.1.1.1 will
# fail. # fail.
check_fib_counter 0 ${nsrouter} 1.1.1.1 || exit 1 check_fib_counter 0 "$nsrouter" 1.1.1.1 || exit 1
check_fib_counter 0 ${nsrouter} 1c3::c01d || exit 1 check_fib_counter 0 "$nsrouter" 1c3::c01d || exit 1
ip netns exec "$ns1" ping -W 0.5 -c 1 -q 1.1.1.1 > /dev/null ip netns exec "$ns1" ping -W 0.5 -c 1 -q 1.1.1.1 > /dev/null
check_fib_counter 1 ${nsrouter} 1.1.1.1 || exit 1 check_fib_counter 1 "$nsrouter" 1.1.1.1 || exit 1
ip netns exec "$ns1" ping -W 0.5 -i 0.1 -c 3 -q 1c3::c01d > /dev/null ip netns exec "$ns1" ping -W 0.5 -i 0.1 -c 3 -q 1c3::c01d > /dev/null
check_fib_counter 3 ${nsrouter} 1c3::c01d || exit 1 check_fib_counter 3 "$nsrouter" 1c3::c01d || exit 1
# delete all rules # delete all rules
ip netns exec ${ns1} nft flush ruleset ip netns exec "$ns1" nft flush ruleset
ip netns exec ${ns2} nft flush ruleset ip netns exec "$ns2" nft flush ruleset
ip netns exec ${nsrouter} nft flush ruleset ip netns exec "$nsrouter" nft flush ruleset
ip -net ${ns1} addr add 10.0.1.99/24 dev eth0 ip -net "$ns1" addr add 10.0.1.99/24 dev eth0
ip -net "$ns1" addr add dead:1::99/64 dev eth0 nodad ip -net "$ns1" addr add dead:1::99/64 dev eth0 nodad
ip -net ${ns1} addr del 10.0.2.99/24 dev eth0 ip -net "$ns1" addr del 10.0.2.99/24 dev eth0
ip -net ${ns1} addr del dead:2::99/64 dev eth0 ip -net "$ns1" addr del dead:2::99/64 dev eth0
ip -net ${nsrouter} addr del dead:2::1/64 dev veth0 ip -net "$nsrouter" addr del dead:2::1/64 dev veth0
# ... pbr ruleset for the router, check iif+oif. # ... pbr ruleset for the router, check iif+oif.
load_pbr_ruleset ${nsrouter} if ! load_pbr_ruleset "$nsrouter";then
if [ $? -ne 0 ] ; then
echo "SKIP: Could not load fib forward ruleset" echo "SKIP: Could not load fib forward ruleset"
exit $ksft_skip exit $ksft_skip
fi fi
ip -net ${nsrouter} rule add from all table 128 ip -net "$nsrouter" rule add from all table 128
ip -net ${nsrouter} rule add from all iif veth0 table 129 ip -net "$nsrouter" rule add from all iif veth0 table 129
ip -net ${nsrouter} route add table 128 to 10.0.1.0/24 dev veth0 ip -net "$nsrouter" route add table 128 to 10.0.1.0/24 dev veth0
ip -net ${nsrouter} route add table 129 to 10.0.2.0/24 dev veth1 ip -net "$nsrouter" route add table 129 to 10.0.2.0/24 dev veth1
# drop main ipv4 table # drop main ipv4 table
ip -net ${nsrouter} -4 rule delete table main ip -net "$nsrouter" -4 rule delete table main
test_ping 10.0.2.99 dead:2::99 if ! test_ping 10.0.2.99 dead:2::99;then
if [ $? -ne 0 ] ; then ip -net "$nsrouter" nft list ruleset
ip -net ${nsrouter} nft list ruleset
echo "FAIL: fib mismatch in pbr setup" echo "FAIL: fib mismatch in pbr setup"
exit 1 exit 1
fi fi
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7