Commit 9c1e0439 authored by Rob Herring's avatar Rob Herring Committed by Mark Brown

ASoC: dt-bindings: Move port/ports properties out of audio-graph-port.yaml

Users of the audio-graph-port schema need to define how many ports
and what each port is, so they need to define 'ports' and/or 'port'
anyways. Let's drop 'ports' and 'port' from the schema and adjust users
to reference audio-graph-port.yaml from a port property.

Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Lubomir Rintel <lkundrak@v3.sk>
Cc: Sameer Pujar <spujar@nvidia.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210331142748.2163272-2-robh@kernel.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent ad858508
...@@ -12,10 +12,6 @@ maintainers: ...@@ -12,10 +12,6 @@ maintainers:
select: false select: false
properties: properties:
port:
description: single OF-Graph subnode
type: object
properties:
reg: reg:
maxItems: 1 maxItems: 1
prefix: prefix:
...@@ -27,7 +23,7 @@ properties: ...@@ -27,7 +23,7 @@ properties:
convert-channels: convert-channels:
description: CPU to Codec rate channels. description: CPU to Codec rate channels.
$ref: /schemas/types.yaml#/definitions/uint32 $ref: /schemas/types.yaml#/definitions/uint32
patternProperties: patternProperties:
"^endpoint(@[0-9a-f]+)?": "^endpoint(@[0-9a-f]+)?":
type: object type: object
properties: properties:
...@@ -71,11 +67,4 @@ properties: ...@@ -71,11 +67,4 @@ properties:
description: CPU to Codec rate channels. description: CPU to Codec rate channels.
$ref: /schemas/types.yaml#/definitions/uint32 $ref: /schemas/types.yaml#/definitions/uint32
ports:
description: multi OF-Graph subnode
type: object
patternProperties:
"^port(@[0-9a-f]+)?":
$ref: "#/properties/port"
additionalProperties: true additionalProperties: true
...@@ -9,9 +9,6 @@ title: Marvel SSPA Digital Audio Interface Bindings ...@@ -9,9 +9,6 @@ title: Marvel SSPA Digital Audio Interface Bindings
maintainers: maintainers:
- Lubomir Rintel <lkundrak@v3.sk> - Lubomir Rintel <lkundrak@v3.sk>
allOf:
- $ref: audio-graph-port.yaml#
properties: properties:
$nodename: $nodename:
pattern: "^audio-controller(@.*)?$" pattern: "^audio-controller(@.*)?$"
...@@ -54,7 +51,8 @@ properties: ...@@ -54,7 +51,8 @@ properties:
- const: rx - const: rx
port: port:
type: object $ref: audio-graph-port.yaml#
unevaluatedProperties: false
properties: properties:
endpoint: endpoint:
......
...@@ -17,9 +17,6 @@ maintainers: ...@@ -17,9 +17,6 @@ maintainers:
- Jon Hunter <jonathanh@nvidia.com> - Jon Hunter <jonathanh@nvidia.com>
- Sameer Pujar <spujar@nvidia.com> - Sameer Pujar <spujar@nvidia.com>
allOf:
- $ref: audio-graph-port.yaml#
properties: properties:
$nodename: $nodename:
pattern: "^dspk@[0-9a-f]*$" pattern: "^dspk@[0-9a-f]*$"
...@@ -59,14 +56,18 @@ properties: ...@@ -59,14 +56,18 @@ properties:
available instances on a Tegra SoC. available instances on a Tegra SoC.
ports: ports:
type: object $ref: /schemas/graph.yaml#/properties/ports
properties: properties:
port@0: port@0:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
description: | description: |
DSPK ACIF (Audio Client Interface) port connected to the DSPK ACIF (Audio Client Interface) port connected to the
corresponding AHUB (Audio Hub) ACIF port. corresponding AHUB (Audio Hub) ACIF port.
port@1: port@1:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
description: | description: |
DSPK DAP (Digital Audio Port) interface which can be connected DSPK DAP (Digital Audio Port) interface which can be connected
to external audio codec for playback. to external audio codec for playback.
...@@ -80,7 +81,7 @@ required: ...@@ -80,7 +81,7 @@ required:
- assigned-clock-parents - assigned-clock-parents
- sound-name-prefix - sound-name-prefix
unevaluatedProperties: false additionalProperties: false
examples: examples:
- | - |
......
...@@ -17,9 +17,6 @@ maintainers: ...@@ -17,9 +17,6 @@ maintainers:
- Jon Hunter <jonathanh@nvidia.com> - Jon Hunter <jonathanh@nvidia.com>
- Sameer Pujar <spujar@nvidia.com> - Sameer Pujar <spujar@nvidia.com>
allOf:
- $ref: audio-graph-port.yaml#
properties: properties:
$nodename: $nodename:
pattern: "^admaif@[0-9a-f]*$" pattern: "^admaif@[0-9a-f]*$"
...@@ -41,6 +38,7 @@ properties: ...@@ -41,6 +38,7 @@ properties:
dma-names: true dma-names: true
ports: ports:
$ref: /schemas/graph.yaml#/properties/ports
description: | description: |
Contains list of ACIF (Audio CIF) port nodes for ADMAIF channels. Contains list of ACIF (Audio CIF) port nodes for ADMAIF channels.
The number of port nodes depends on the number of ADMAIF channels The number of port nodes depends on the number of ADMAIF channels
...@@ -48,6 +46,11 @@ properties: ...@@ -48,6 +46,11 @@ properties:
in AHUB (Audio Hub). Each port is capable of data transfers in in AHUB (Audio Hub). Each port is capable of data transfers in
both directions. both directions.
patternProperties:
'^port@[0-9]':
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
if: if:
properties: properties:
compatible: compatible:
...@@ -92,7 +95,7 @@ required: ...@@ -92,7 +95,7 @@ required:
- dmas - dmas
- dma-names - dma-names
unevaluatedProperties: false additionalProperties: false
examples: examples:
- | - |
......
...@@ -17,9 +17,6 @@ maintainers: ...@@ -17,9 +17,6 @@ maintainers:
- Jon Hunter <jonathanh@nvidia.com> - Jon Hunter <jonathanh@nvidia.com>
- Sameer Pujar <spujar@nvidia.com> - Sameer Pujar <spujar@nvidia.com>
allOf:
- $ref: audio-graph-port.yaml#
properties: properties:
$nodename: $nodename:
pattern: "^ahub@[0-9a-f]*$" pattern: "^ahub@[0-9a-f]*$"
...@@ -60,12 +57,18 @@ properties: ...@@ -60,12 +57,18 @@ properties:
ranges: true ranges: true
ports: ports:
$ref: /schemas/graph.yaml#/properties/ports
description: | description: |
Contains list of ACIF (Audio CIF) port nodes for AHUB (Audio Hub). Contains list of ACIF (Audio CIF) port nodes for AHUB (Audio Hub).
These are connected to ACIF interfaces of AHUB clients. Thus the These are connected to ACIF interfaces of AHUB clients. Thus the
number of port nodes depend on the number of clients that AHUB may number of port nodes depend on the number of clients that AHUB may
have depending on the SoC revision. have depending on the SoC revision.
patternProperties:
'^port@[0-9]':
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
patternProperties: patternProperties:
'^i2s@[0-9a-f]+$': '^i2s@[0-9a-f]+$':
type: object type: object
...@@ -93,7 +96,7 @@ required: ...@@ -93,7 +96,7 @@ required:
- "#size-cells" - "#size-cells"
- ranges - ranges
unevaluatedProperties: false additionalProperties: false
examples: examples:
- | - |
......
...@@ -16,9 +16,6 @@ maintainers: ...@@ -16,9 +16,6 @@ maintainers:
- Jon Hunter <jonathanh@nvidia.com> - Jon Hunter <jonathanh@nvidia.com>
- Sameer Pujar <spujar@nvidia.com> - Sameer Pujar <spujar@nvidia.com>
allOf:
- $ref: audio-graph-port.yaml#
properties: properties:
$nodename: $nodename:
pattern: "^dmic@[0-9a-f]*$" pattern: "^dmic@[0-9a-f]*$"
...@@ -60,14 +57,18 @@ properties: ...@@ -60,14 +57,18 @@ properties:
on the maximum available instances on a Tegra SoC. on the maximum available instances on a Tegra SoC.
ports: ports:
type: object $ref: /schemas/graph.yaml#/properties/ports
properties: properties:
port@0: port@0:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
description: | description: |
DMIC ACIF (Audio Client Interface) port connected to the DMIC ACIF (Audio Client Interface) port connected to the
corresponding AHUB (Audio Hub) ACIF port. corresponding AHUB (Audio Hub) ACIF port.
port@1: port@1:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
description: | description: |
DMIC DAP (Digital Audio Port) interface which can be connected DMIC DAP (Digital Audio Port) interface which can be connected
to external audio codec for capture. to external audio codec for capture.
...@@ -80,7 +81,7 @@ required: ...@@ -80,7 +81,7 @@ required:
- assigned-clocks - assigned-clocks
- assigned-clock-parents - assigned-clock-parents
unevaluatedProperties: false additionalProperties: false
examples: examples:
- | - |
......
...@@ -16,9 +16,6 @@ maintainers: ...@@ -16,9 +16,6 @@ maintainers:
- Jon Hunter <jonathanh@nvidia.com> - Jon Hunter <jonathanh@nvidia.com>
- Sameer Pujar <spujar@nvidia.com> - Sameer Pujar <spujar@nvidia.com>
allOf:
- $ref: audio-graph-port.yaml#
properties: properties:
$nodename: $nodename:
pattern: "^i2s@[0-9a-f]*$" pattern: "^i2s@[0-9a-f]*$"
...@@ -78,14 +75,18 @@ properties: ...@@ -78,14 +75,18 @@ properties:
on the maximum available instances on a Tegra SoC. on the maximum available instances on a Tegra SoC.
ports: ports:
type: object $ref: /schemas/graph.yaml#/properties/ports
properties: properties:
port@0: port@0:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
description: | description: |
I2S ACIF (Audio Client Interface) port connected to the I2S ACIF (Audio Client Interface) port connected to the
corresponding AHUB (Audio Hub) ACIF port. corresponding AHUB (Audio Hub) ACIF port.
port@1: port@1:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
description: | description: |
I2S DAP (Digital Audio Port) interface which can be connected I2S DAP (Digital Audio Port) interface which can be connected
to external audio codec for playback or capture. to external audio codec for playback or capture.
...@@ -98,7 +99,7 @@ required: ...@@ -98,7 +99,7 @@ required:
- assigned-clocks - assigned-clocks
- assigned-clock-parents - assigned-clock-parents
unevaluatedProperties: false additionalProperties: false
examples: examples:
- | - |
......
...@@ -111,7 +111,9 @@ properties: ...@@ -111,7 +111,9 @@ properties:
- pattern: '^dvc\.[0-1]$' - pattern: '^dvc\.[0-1]$'
- pattern: '^clk_(a|b|c|i)$' - pattern: '^clk_(a|b|c|i)$'
port: true port:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
# use patternProperties to avoid naming "xxx,yyy" issue # use patternProperties to avoid naming "xxx,yyy" issue
patternProperties: patternProperties:
...@@ -257,7 +259,6 @@ required: ...@@ -257,7 +259,6 @@ required:
allOf: allOf:
- $ref: audio-graph.yaml# - $ref: audio-graph.yaml#
- $ref: audio-graph-port.yaml#
- if: - if:
properties: properties:
compatible: compatible:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment