Commit 9f42cf54 authored by Fabien Parent's avatar Fabien Parent Committed by Viresh Kumar

cpufreq: qcom: fix memory leak in error path

If for some reason the speedbin length is incorrect, then there is a
memory leak in the error path because we never free the speedbin buffer.
This commit fixes the error path to always free the speedbin buffer.

Cc: v5.7+ <stable@vger.kernel.org> # v5.7+
Fixes: a8811ec7 ("cpufreq: qcom: Add support for krait based socs")
Signed-off-by: default avatarFabien Parent <fabien.parent@linaro.org>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 1dcaf307
...@@ -213,6 +213,7 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev, ...@@ -213,6 +213,7 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev,
int speed = 0, pvs = 0, pvs_ver = 0; int speed = 0, pvs = 0, pvs_ver = 0;
u8 *speedbin; u8 *speedbin;
size_t len; size_t len;
int ret = 0;
speedbin = nvmem_cell_read(speedbin_nvmem, &len); speedbin = nvmem_cell_read(speedbin_nvmem, &len);
...@@ -230,7 +231,8 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev, ...@@ -230,7 +231,8 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev,
break; break;
default: default:
dev_err(cpu_dev, "Unable to read nvmem data. Defaulting to 0!\n"); dev_err(cpu_dev, "Unable to read nvmem data. Defaulting to 0!\n");
return -ENODEV; ret = -ENODEV;
goto len_error;
} }
snprintf(*pvs_name, sizeof("speedXX-pvsXX-vXX"), "speed%d-pvs%d-v%d", snprintf(*pvs_name, sizeof("speedXX-pvsXX-vXX"), "speed%d-pvs%d-v%d",
...@@ -238,8 +240,9 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev, ...@@ -238,8 +240,9 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev,
drv->versions = (1 << speed); drv->versions = (1 << speed);
len_error:
kfree(speedbin); kfree(speedbin);
return 0; return ret;
} }
static const struct qcom_cpufreq_match_data match_data_kryo = { static const struct qcom_cpufreq_match_data match_data_kryo = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment