Commit a1fb79b7 authored by Yihao Wu's avatar Yihao Wu Committed by Kleber Sacilotto de Souza

nfsd: fix wrong check in write_v4_end_grace()

BugLink: https://bugs.launchpad.net/bugs/1822271

commit dd838821 upstream.

Commit 62a063b8 "nfsd4: fix crash on writing v4_end_grace before
nfsd startup" is trying to fix a NULL dereference issue, but it
mistakenly checks if the nfsd server is started. So fix it.

Fixes: 62a063b8 "nfsd4: fix crash on writing v4_end_grace before nfsd startup"
Cc: stable@vger.kernel.org
Reviewed-by: default avatarJoseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: default avatarYihao Wu <wuyihao@linux.alibaba.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
Acked-by: default avatarJuerg Haefliger <juerg.haefliger@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 4b93a13f
...@@ -1106,7 +1106,7 @@ static ssize_t write_v4_end_grace(struct file *file, char *buf, size_t size) ...@@ -1106,7 +1106,7 @@ static ssize_t write_v4_end_grace(struct file *file, char *buf, size_t size)
case 'Y': case 'Y':
case 'y': case 'y':
case '1': case '1':
if (nn->nfsd_serv) if (!nn->nfsd_serv)
return -EBUSY; return -EBUSY;
nfsd4_end_grace(nn); nfsd4_end_grace(nn);
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment