Commit a2125d02 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Guenter Roeck

hwmon: (asus_atk0110) fix uninitialized data access

The latest gcc-7 snapshot adds a warning to point out that when
atk_read_value_old or atk_read_value_new fails, we copy
uninitialized data into sensor->cached_value:

drivers/hwmon/asus_atk0110.c: In function 'atk_input_show':
drivers/hwmon/asus_atk0110.c:651:26: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Adding an error check avoids this. All versions of the driver
are affected.

Fixes: 2c03d07a ("hwmon: Add Asus ATK0110 support")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarLuca Tettamanti <kronos.it@gmail.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a5023a99
...@@ -646,6 +646,9 @@ static int atk_read_value(struct atk_sensor_data *sensor, u64 *value) ...@@ -646,6 +646,9 @@ static int atk_read_value(struct atk_sensor_data *sensor, u64 *value)
else else
err = atk_read_value_new(sensor, value); err = atk_read_value_new(sensor, value);
if (err)
return err;
sensor->is_valid = true; sensor->is_valid = true;
sensor->last_updated = jiffies; sensor->last_updated = jiffies;
sensor->cached_value = *value; sensor->cached_value = *value;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment