Commit a29054d9 authored by Steven Rostedt (Red Hat)'s avatar Steven Rostedt (Red Hat) Committed by Steven Rostedt

tracing: Fix crash from reading trace_pipe with sendfile

If tracing contains data and the trace_pipe file is read with sendfile(),
then it can trigger a NULL pointer dereference and various BUG_ON within the
VM code.

There's a patch to fix this in the splice_to_pipe() code, but it's also a
good idea to not let that happen from trace_pipe either.

Link: http://lkml.kernel.org/r/1457641146-9068-1-git-send-email-rabin@rab.in

Cc: stable@vger.kernel.org # 2.6.30+
Reported-by: default avatarRabin Vincent <rabin.vincent@gmail.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent cb86e053
...@@ -4954,7 +4954,10 @@ static ssize_t tracing_splice_read_pipe(struct file *filp, ...@@ -4954,7 +4954,10 @@ static ssize_t tracing_splice_read_pipe(struct file *filp,
spd.nr_pages = i; spd.nr_pages = i;
if (i)
ret = splice_to_pipe(pipe, &spd); ret = splice_to_pipe(pipe, &spd);
else
ret = 0;
out: out:
splice_shrink_spd(&spd); splice_shrink_spd(&spd);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment