Commit a30fc787 authored by Cai Huoqing's avatar Cai Huoqing Committed by Sam Ravnborg

drm/panel: k101-im2ba02: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Acked-by: default avatarIcenowy Zheng <icenowy@aosc.io>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916104247.11270-1-caihuoqing@baidu.com
parent 386e1c18
...@@ -456,16 +456,13 @@ static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi) ...@@ -456,16 +456,13 @@ static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi)
ret = devm_regulator_bulk_get(&dsi->dev, ARRAY_SIZE(ctx->supplies), ret = devm_regulator_bulk_get(&dsi->dev, ARRAY_SIZE(ctx->supplies),
ctx->supplies); ctx->supplies);
if (ret < 0) { if (ret < 0)
dev_err(&dsi->dev, "Couldn't get regulators\n"); return dev_err_probe(&dsi->dev, ret, "Couldn't get regulators\n");
return ret;
}
ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(ctx->reset)) { if (IS_ERR(ctx->reset))
dev_err(&dsi->dev, "Couldn't get our reset GPIO\n"); return dev_err_probe(&dsi->dev, PTR_ERR(ctx->reset),
return PTR_ERR(ctx->reset); "Couldn't get our reset GPIO\n");
}
drm_panel_init(&ctx->panel, &dsi->dev, &k101_im2ba02_funcs, drm_panel_init(&ctx->panel, &dsi->dev, &k101_im2ba02_funcs,
DRM_MODE_CONNECTOR_DSI); DRM_MODE_CONNECTOR_DSI);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment