Commit a3c10bed authored by Dan Carpenter's avatar Dan Carpenter Committed by Gao Xiang

erofs: silence uninitialized variable warning in z_erofs_scan_folio()

Smatch complains that:

    fs/erofs/zdata.c:1047 z_erofs_scan_folio()
    error: uninitialized symbol 'err'.

The issue is if we hit this (!(map->m_flags & EROFS_MAP_MAPPED)) {
condition then "err" isn't set.  It's inside a loop so we would have to
hit that condition on every iteration.  Initialize "err" to zero to
solve this.

Fixes: 5b9654ef ("erofs: teach z_erofs_scan_folios() to handle multi-page folios")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/f78ab50e-ed6d-4275-8dd4-a4159fa565a2@stanley.mountainSigned-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
parent 1001042e
...@@ -962,7 +962,7 @@ static int z_erofs_scan_folio(struct z_erofs_decompress_frontend *f, ...@@ -962,7 +962,7 @@ static int z_erofs_scan_folio(struct z_erofs_decompress_frontend *f,
const unsigned int bs = i_blocksize(inode); const unsigned int bs = i_blocksize(inode);
unsigned int end = folio_size(folio), split = 0, cur, pgs; unsigned int end = folio_size(folio), split = 0, cur, pgs;
bool tight, excl; bool tight, excl;
int err; int err = 0;
tight = (bs == PAGE_SIZE); tight = (bs == PAGE_SIZE);
z_erofs_onlinefolio_init(folio); z_erofs_onlinefolio_init(folio);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment