Commit a41b2ea7 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab

V4L/DVB: cx88: improve error handling

Return -EINVAL if we don't find the right query control id.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 8e47567f
...@@ -1538,9 +1538,12 @@ static int radio_queryctrl (struct file *file, void *priv, ...@@ -1538,9 +1538,12 @@ static int radio_queryctrl (struct file *file, void *priv,
c->id >= V4L2_CID_LASTP1) c->id >= V4L2_CID_LASTP1)
return -EINVAL; return -EINVAL;
if (c->id == V4L2_CID_AUDIO_MUTE) { if (c->id == V4L2_CID_AUDIO_MUTE) {
for (i = 0; i < CX8800_CTLS; i++) for (i = 0; i < CX8800_CTLS; i++) {
if (cx8800_ctls[i].v.id == c->id) if (cx8800_ctls[i].v.id == c->id)
break; break;
}
if (i == CX8800_CTLS)
return -EINVAL;
*c = cx8800_ctls[i].v; *c = cx8800_ctls[i].v;
} else } else
*c = no_ctl; *c = no_ctl;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment