Commit a482766d authored by Bixuan Cui's avatar Bixuan Cui Committed by Greg Kroah-Hartman

usb: usbtest: reduce stack usage in test_queue

Fix the warning: [-Werror=-Wframe-larger-than=]

drivers/usb/misc/usbtest.c: In function 'test_queue':
drivers/usb/misc/usbtest.c:2148:1:
warning: the frame size of 1232 bytes is larger than 1024 bytes
Reported-by: default avatarkbuild test robot <lkp@intel.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarBixuan Cui <cuibixuan@huawei.com>
Link: https://lore.kernel.org/r/ffa85702-86ab-48d7-4da2-2efcc94b05d3@huawei.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6e1c2241
...@@ -2043,7 +2043,7 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param, ...@@ -2043,7 +2043,7 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param,
unsigned i; unsigned i;
unsigned long packets = 0; unsigned long packets = 0;
int status = 0; int status = 0;
struct urb *urbs[MAX_SGLEN]; struct urb **urbs;
if (!param->sglen || param->iterations > UINT_MAX / param->sglen) if (!param->sglen || param->iterations > UINT_MAX / param->sglen)
return -EINVAL; return -EINVAL;
...@@ -2051,6 +2051,10 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param, ...@@ -2051,6 +2051,10 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param,
if (param->sglen > MAX_SGLEN) if (param->sglen > MAX_SGLEN)
return -EINVAL; return -EINVAL;
urbs = kcalloc(param->sglen, sizeof(*urbs), GFP_KERNEL);
if (!urbs)
return -ENOMEM;
memset(&context, 0, sizeof(context)); memset(&context, 0, sizeof(context));
context.count = param->iterations * param->sglen; context.count = param->iterations * param->sglen;
context.dev = dev; context.dev = dev;
...@@ -2137,6 +2141,8 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param, ...@@ -2137,6 +2141,8 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param,
else if (context.errors > else if (context.errors >
(context.is_iso ? context.packet_count / 10 : 0)) (context.is_iso ? context.packet_count / 10 : 0))
status = -EIO; status = -EIO;
kfree(urbs);
return status; return status;
fail: fail:
...@@ -2144,6 +2150,8 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param, ...@@ -2144,6 +2150,8 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param,
if (urbs[i]) if (urbs[i])
simple_free_urb(urbs[i]); simple_free_urb(urbs[i]);
} }
kfree(urbs);
return status; return status;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment