Commit a4af49f3 authored by Oliver O'Halloran's avatar Oliver O'Halloran Committed by Michael Ellerman

powerpc/pcidn: Warn when sriov pci_dn management is used incorrectly

These functions can only be used on a SR-IOV capable physical function and
they're only called in pcibios_sriov_enable / disable. Make them emit a
warning in the future if they're used incorrectly and remove the dead
code that checks if the device is a VF.
Signed-off-by: default avatarOliver O'Halloran <oohall@gmail.com>
Reviewed-by: default avatarSam Bobroff <sbobroff@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190821062655.19735-3-oohall@gmail.com
parent 8cd6aacc
...@@ -158,8 +158,8 @@ struct pci_dn *add_sriov_vf_pdns(struct pci_dev *pdev) ...@@ -158,8 +158,8 @@ struct pci_dn *add_sriov_vf_pdns(struct pci_dev *pdev)
int i; int i;
/* Only support IOV for now */ /* Only support IOV for now */
if (!pdev->is_physfn) if (WARN_ON(!pdev->is_physfn))
return pci_get_pdn(pdev); return NULL;
/* Check if VFs have been populated */ /* Check if VFs have been populated */
pdn = pci_get_pdn(pdev); pdn = pci_get_pdn(pdev);
...@@ -199,19 +199,8 @@ void remove_sriov_vf_pdns(struct pci_dev *pdev) ...@@ -199,19 +199,8 @@ void remove_sriov_vf_pdns(struct pci_dev *pdev)
struct pci_dn *pdn, *tmp; struct pci_dn *pdn, *tmp;
int i; int i;
/*
* VF and VF PE are created/released dynamically, so we need to
* bind/unbind them. Otherwise the VF and VF PE would be mismatched
* when re-enabling SR-IOV.
*/
if (pdev->is_virtfn) {
pdn = pci_get_pdn(pdev);
pdn->pe_number = IODA_INVALID_PE;
return;
}
/* Only support IOV PF for now */ /* Only support IOV PF for now */
if (!pdev->is_physfn) if (WARN_ON(!pdev->is_physfn))
return; return;
/* Check if VFs have been populated */ /* Check if VFs have been populated */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment