Commit a59c16c8 authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno Committed by Stephen Boyd

clk: qcom: gpucc-msm8998: Add resets, cxc, fix flags on gpu_gx_gdsc

The GPU GX GDSC has GPU_GX_BCR reset and gfx3d_clk CXC, as stated
on downstream kernels (and as verified upstream, because otherwise
random lockups happen).
Also, add PWRSTS_RET and NO_RET_PERIPH: also as found downstream,
and also as verified here, to avoid GPU related lockups it is
necessary to force retain mem, but *not* peripheral when enabling
this GDSC (and, of course, the inverse on disablement).

With this change, the GPU finally works flawlessly on my four
different MSM8998 devices from two different manufacturers.
Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Link: https://lore.kernel.org/r/20210114221059.483390-11-angelogioacchino.delregno@somainline.orgSigned-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 785c02eb
...@@ -253,12 +253,16 @@ static struct gdsc gpu_cx_gdsc = { ...@@ -253,12 +253,16 @@ static struct gdsc gpu_cx_gdsc = {
static struct gdsc gpu_gx_gdsc = { static struct gdsc gpu_gx_gdsc = {
.gdscr = 0x1094, .gdscr = 0x1094,
.clamp_io_ctrl = 0x130, .clamp_io_ctrl = 0x130,
.resets = (unsigned int []){ GPU_GX_BCR },
.reset_count = 1,
.cxcs = (unsigned int []){ 0x1098 },
.cxc_count = 1,
.pd = { .pd = {
.name = "gpu_gx", .name = "gpu_gx",
}, },
.parent = &gpu_cx_gdsc.pd, .parent = &gpu_cx_gdsc.pd,
.pwrsts = PWRSTS_OFF_ON, .pwrsts = PWRSTS_OFF_ON | PWRSTS_RET,
.flags = CLAMP_IO | AON_RESET, .flags = CLAMP_IO | SW_RESET | AON_RESET | NO_RET_PERIPH,
}; };
static struct clk_regmap *gpucc_msm8998_clocks[] = { static struct clk_regmap *gpucc_msm8998_clocks[] = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment