Commit a8b279d9 authored by Tejun Heo's avatar Tejun Heo Committed by Luis Henriques

blkcg: fix gendisk reference leak in blkg_conf_prep()

commit 5f6c2d2b upstream.

When a blkcg configuration is targeted to a partition rather than a
whole device, blkg_conf_prep fails with -EINVAL; unfortunately, it
forgets to put the gendisk ref in that case.  Fix it.
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 8efc9fc6
...@@ -716,8 +716,12 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol, ...@@ -716,8 +716,12 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
return -EINVAL; return -EINVAL;
disk = get_gendisk(MKDEV(major, minor), &part); disk = get_gendisk(MKDEV(major, minor), &part);
if (!disk || part) if (!disk)
return -EINVAL; return -EINVAL;
if (part) {
put_disk(disk);
return -EINVAL;
}
rcu_read_lock(); rcu_read_lock();
spin_lock_irq(disk->queue->queue_lock); spin_lock_irq(disk->queue->queue_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment