Commit a9ef5c47 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Felipe Balbi

usb: gadget: udc: USB_SNP_CORE should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "usb_gadget_map_request" [drivers/usb/gadget/udc/snps_udc_core.ko] undefined!
    ERROR: "dma_pool_destroy" [drivers/usb/gadget/udc/snps_udc_core.ko] undefined!
    ERROR: "usb_gadget_unmap_request" [drivers/usb/gadget/udc/snps_udc_core.ko] undefined!
    ERROR: "dma_pool_free" [drivers/usb/gadget/udc/snps_udc_core.ko] undefined!
    ERROR: "dma_pool_alloc" [drivers/usb/gadget/udc/snps_udc_core.ko] undefined!
    ERROR: "dma_pool_create" [drivers/usb/gadget/udc/snps_udc_core.ko] undefined!

As USB_SNP_CORE is selected by USB_SNP_UDC_PLAT and USB_AMD5536UDC,
these should depend on HAS_DMA, too.  For USB_AMD5536UDC, this is
already fulfilled through the dependency on USB_PCI (PCI implies
HAS_DMA).

Add dependencies on HAS_DMA to fix this.
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent f84a31eb
...@@ -257,6 +257,7 @@ config USB_MV_U3D ...@@ -257,6 +257,7 @@ config USB_MV_U3D
config USB_SNP_CORE config USB_SNP_CORE
depends on (USB_AMD5536UDC || USB_SNP_UDC_PLAT) depends on (USB_AMD5536UDC || USB_SNP_UDC_PLAT)
depends on HAS_DMA
tristate tristate
help help
This enables core driver support for Synopsys USB 2.0 Device This enables core driver support for Synopsys USB 2.0 Device
...@@ -271,7 +272,7 @@ config USB_SNP_CORE ...@@ -271,7 +272,7 @@ config USB_SNP_CORE
config USB_SNP_UDC_PLAT config USB_SNP_UDC_PLAT
tristate "Synopsys USB 2.0 Device controller" tristate "Synopsys USB 2.0 Device controller"
depends on (USB_GADGET && OF) depends on USB_GADGET && OF && HAS_DMA
select USB_GADGET_DUALSPEED select USB_GADGET_DUALSPEED
select USB_SNP_CORE select USB_SNP_CORE
default ARCH_BCM_IPROC default ARCH_BCM_IPROC
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment