Commit ac019360 authored by Jeff Garzik's avatar Jeff Garzik Committed by David S. Miller

[Bluetooth] Eliminate checks for impossible conditions in IRQ handler

Our info structure and info->hdev is always passed to the IRQ handler,
so we don't have to worry about these checks in every interrupt.

Leave a BUG_ON() just to help unwary programmers, but these could
probably be removed as well.
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 166d2f6a
...@@ -503,10 +503,7 @@ static irqreturn_t bluecard_interrupt(int irq, void *dev_inst) ...@@ -503,10 +503,7 @@ static irqreturn_t bluecard_interrupt(int irq, void *dev_inst)
unsigned int iobase; unsigned int iobase;
unsigned char reg; unsigned char reg;
if (!info || !info->hdev) { BUG_ON(!info->hdev);
BT_ERR("Call of irq %d for unknown device", irq);
return IRQ_NONE;
}
if (!test_bit(CARD_READY, &(info->hw_state))) if (!test_bit(CARD_READY, &(info->hw_state)))
return IRQ_HANDLED; return IRQ_HANDLED;
......
...@@ -344,10 +344,7 @@ static irqreturn_t bt3c_interrupt(int irq, void *dev_inst) ...@@ -344,10 +344,7 @@ static irqreturn_t bt3c_interrupt(int irq, void *dev_inst)
unsigned int iobase; unsigned int iobase;
int iir; int iir;
if (!info || !info->hdev) { BUG_ON(!info->hdev);
BT_ERR("Call of irq %d for unknown device", irq);
return IRQ_NONE;
}
iobase = info->p_dev->io.BasePort1; iobase = info->p_dev->io.BasePort1;
......
...@@ -294,10 +294,7 @@ static irqreturn_t btuart_interrupt(int irq, void *dev_inst) ...@@ -294,10 +294,7 @@ static irqreturn_t btuart_interrupt(int irq, void *dev_inst)
int boguscount = 0; int boguscount = 0;
int iir, lsr; int iir, lsr;
if (!info || !info->hdev) { BUG_ON(!info->hdev);
BT_ERR("Call of irq %d for unknown device", irq);
return IRQ_NONE;
}
iobase = info->p_dev->io.BasePort1; iobase = info->p_dev->io.BasePort1;
......
...@@ -298,10 +298,7 @@ static irqreturn_t dtl1_interrupt(int irq, void *dev_inst) ...@@ -298,10 +298,7 @@ static irqreturn_t dtl1_interrupt(int irq, void *dev_inst)
int boguscount = 0; int boguscount = 0;
int iir, lsr; int iir, lsr;
if (!info || !info->hdev) { BUG_ON(!info->hdev);
BT_ERR("Call of irq %d for unknown device", irq);
return IRQ_NONE;
}
iobase = info->p_dev->io.BasePort1; iobase = info->p_dev->io.BasePort1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment