Commit ac1f12ef authored by Dan Carpenter's avatar Dan Carpenter Committed by Sage Weil

ceph: ceph_get_inode() returns an ERR_PTR

ceph_get_inode() returns an ERR_PTR and it doesn't return a NULL.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarSage Weil <sage@newdream.net>
parent 36e21687
...@@ -1230,11 +1230,11 @@ int ceph_readdir_prepopulate(struct ceph_mds_request *req, ...@@ -1230,11 +1230,11 @@ int ceph_readdir_prepopulate(struct ceph_mds_request *req,
in = dn->d_inode; in = dn->d_inode;
} else { } else {
in = ceph_get_inode(parent->d_sb, vino); in = ceph_get_inode(parent->d_sb, vino);
if (in == NULL) { if (IS_ERR(in)) {
dout("new_inode badness\n"); dout("new_inode badness\n");
d_delete(dn); d_delete(dn);
dput(dn); dput(dn);
err = -ENOMEM; err = PTR_ERR(in);
goto out; goto out;
} }
dn = splice_dentry(dn, in, NULL); dn = splice_dentry(dn, in, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment