Commit ad5a88c5 authored by Chao Yu's avatar Chao Yu Committed by Greg Kroah-Hartman

ext4: check return value of kstrtoull correctly in reserved_clusters_store

commit 1ea1516f upstream.

kstrtoull returns 0 on success, however, in reserved_clusters_store we
will return -EINVAL if kstrtoull returns 0, it makes us fail to update
reserved_clusters value through sysfs.

Fixes: 76d33bcaSigned-off-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarMiao Xie <miaoxie@huawei.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cb2bc13d
...@@ -100,7 +100,7 @@ static ssize_t reserved_clusters_store(struct ext4_attr *a, ...@@ -100,7 +100,7 @@ static ssize_t reserved_clusters_store(struct ext4_attr *a,
int ret; int ret;
ret = kstrtoull(skip_spaces(buf), 0, &val); ret = kstrtoull(skip_spaces(buf), 0, &val);
if (!ret || val >= clusters) if (ret || val >= clusters)
return -EINVAL; return -EINVAL;
atomic64_set(&sbi->s_resv_clusters, val); atomic64_set(&sbi->s_resv_clusters, val);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment