Commit ad913da6 authored by Daniel Drake's avatar Daniel Drake Committed by Paul Mundt

lxfb: Program panel v/h sync output polarity correctly

Commit b5c26f97 introduced some breakage for the OLPC XO-1 laptop,
differences in the output video signal after the patch caused some problems
with the XO's display controller chip.

Reviewing of that commit against the AMD Geode LX Data Book, it seems
that these bits were being set inversely. In both cases, active high
output is denoted by a value of 0. See section 6.8.3.44 of the databook
from February 2009 (Publication ID: 33234H)
Signed-off-by: default avatarDaniel Drake <dsd@laptop.org>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent 1e7c7804
...@@ -276,10 +276,10 @@ static void lx_graphics_enable(struct fb_info *info) ...@@ -276,10 +276,10 @@ static void lx_graphics_enable(struct fb_info *info)
write_fp(par, FP_PT1, 0); write_fp(par, FP_PT1, 0);
temp = FP_PT2_SCRC; temp = FP_PT2_SCRC;
if (info->var.sync & FB_SYNC_HOR_HIGH_ACT) if (!(info->var.sync & FB_SYNC_HOR_HIGH_ACT))
temp |= FP_PT2_HSP; temp |= FP_PT2_HSP;
if (info->var.sync & FB_SYNC_VERT_HIGH_ACT) if (!(info->var.sync & FB_SYNC_VERT_HIGH_ACT))
temp |= FP_PT2_VSP; temp |= FP_PT2_VSP;
write_fp(par, FP_PT2, temp); write_fp(par, FP_PT2, temp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment