Commit ae55e59d authored by Trond Myklebust's avatar Trond Myklebust

pnfs: Don't release the sequence slot until we've processed layoutget on open

If the server recalls the layout that was just handed out, we risk hitting
a race as described in RFC5661 Section 2.10.6.3 unless we ensure that we
release the sequence slot after processing the LAYOUTGET operation that
was sent as part of the OPEN compound.
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 32f1c28f
...@@ -2789,7 +2789,7 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, ...@@ -2789,7 +2789,7 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata,
if (ret != 0) if (ret != 0)
goto out; goto out;
state = nfs4_opendata_to_nfs4_state(opendata); state = _nfs4_opendata_to_nfs4_state(opendata);
ret = PTR_ERR(state); ret = PTR_ERR(state);
if (IS_ERR(state)) if (IS_ERR(state))
goto out; goto out;
...@@ -2828,6 +2828,7 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, ...@@ -2828,6 +2828,7 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata,
} }
out: out:
nfs4_sequence_free_slot(&opendata->o_res.seq_res);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment