Commit ae611d07 authored by Miaohe Lin's avatar Miaohe Lin Committed by Linus Torvalds

mm/hwpoison: remove unneeded variable unmap_success

Patch series "Cleanups and fixup for hwpoison"

This series contains cleanups to remove unneeded variable, fix some
obsolete comments and so on.  Also we fix potential pte_unmap_unlock on
wrong pte.  More details can be found in the respective changelogs.

This patch (of 4):

unmap_success is used to indicate whether page is successfully unmapped
but it's irrelated with ZONE_DEVICE page and unmap_success is always true
here.  Remove this unneeded one.

Link: https://lkml.kernel.org/r/20210814105131.48814-1-linmiaohe@huawei.com
Link: https://lkml.kernel.org/r/20210814105131.48814-2-linmiaohe@huawei.comSigned-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Acked-by: default avatarNaoya Horiguchi <naoya.horiguchi@nec.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1d09510b
...@@ -1518,7 +1518,6 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, ...@@ -1518,7 +1518,6 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags,
struct dev_pagemap *pgmap) struct dev_pagemap *pgmap)
{ {
struct page *page = pfn_to_page(pfn); struct page *page = pfn_to_page(pfn);
const bool unmap_success = true;
unsigned long size = 0; unsigned long size = 0;
struct to_kill *tk; struct to_kill *tk;
LIST_HEAD(tokill); LIST_HEAD(tokill);
...@@ -1590,7 +1589,7 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, ...@@ -1590,7 +1589,7 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags,
start = (page->index << PAGE_SHIFT) & ~(size - 1); start = (page->index << PAGE_SHIFT) & ~(size - 1);
unmap_mapping_range(page->mapping, start, size, 0); unmap_mapping_range(page->mapping, start, size, 0);
} }
kill_procs(&tokill, flags & MF_MUST_KILL, !unmap_success, pfn, flags); kill_procs(&tokill, flags & MF_MUST_KILL, false, pfn, flags);
rc = 0; rc = 0;
unlock: unlock:
dax_unlock_page(page, cookie); dax_unlock_page(page, cookie);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment