Commit af138470 authored by Vlad Yasevich's avatar Vlad Yasevich Committed by David S. Miller

sctp: remove useless arguments from get_saddr() call

There is no point in passing a destination address to
a get_saddr() call.
Signed-off-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: default avatarWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9c6a02f4
...@@ -571,7 +571,6 @@ struct sctp_af { ...@@ -571,7 +571,6 @@ struct sctp_af {
struct sock *sk); struct sock *sk);
void (*get_saddr) (struct sctp_sock *sk, void (*get_saddr) (struct sctp_sock *sk,
struct sctp_transport *t, struct sctp_transport *t,
union sctp_addr *daddr,
struct flowi *fl); struct flowi *fl);
void (*copy_addrlist) (struct list_head *, void (*copy_addrlist) (struct list_head *,
struct net_device *); struct net_device *);
......
...@@ -365,15 +365,12 @@ static inline int sctp_v6_addr_match_len(union sctp_addr *s1, ...@@ -365,15 +365,12 @@ static inline int sctp_v6_addr_match_len(union sctp_addr *s1,
*/ */
static void sctp_v6_get_saddr(struct sctp_sock *sk, static void sctp_v6_get_saddr(struct sctp_sock *sk,
struct sctp_transport *t, struct sctp_transport *t,
union sctp_addr *daddr,
struct flowi *fl) struct flowi *fl)
{ {
struct flowi6 *fl6 = &fl->u.ip6; struct flowi6 *fl6 = &fl->u.ip6;
union sctp_addr *saddr = &t->saddr; union sctp_addr *saddr = &t->saddr;
SCTP_DEBUG_PRINTK("%s: asoc:%p dst:%p daddr:%pI6 ", SCTP_DEBUG_PRINTK("%s: asoc:%p dst:%p\n", __func__, t->asoc, t->dst);
__func__, t->asoc, t->dst, &daddr->v6.sin6_addr);
if (t->dst) { if (t->dst) {
saddr->v6.sin6_family = AF_INET6; saddr->v6.sin6_family = AF_INET6;
......
...@@ -562,7 +562,6 @@ static struct dst_entry *sctp_v4_get_dst(struct sctp_association *asoc, ...@@ -562,7 +562,6 @@ static struct dst_entry *sctp_v4_get_dst(struct sctp_association *asoc,
*/ */
static void sctp_v4_get_saddr(struct sctp_sock *sk, static void sctp_v4_get_saddr(struct sctp_sock *sk,
struct sctp_transport *t, struct sctp_transport *t,
union sctp_addr *daddr,
struct flowi *fl) struct flowi *fl)
{ {
union sctp_addr *saddr = &t->saddr; union sctp_addr *saddr = &t->saddr;
......
...@@ -284,7 +284,7 @@ void sctp_transport_route(struct sctp_transport *transport, ...@@ -284,7 +284,7 @@ void sctp_transport_route(struct sctp_transport *transport,
if (saddr) if (saddr)
memcpy(&transport->saddr, saddr, sizeof(union sctp_addr)); memcpy(&transport->saddr, saddr, sizeof(union sctp_addr));
else else
af->get_saddr(opt, transport, daddr, &fl); af->get_saddr(opt, transport, &fl);
if ((transport->param_flags & SPP_PMTUD_DISABLE) && transport->pathmtu) { if ((transport->param_flags & SPP_PMTUD_DISABLE) && transport->pathmtu) {
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment