Commit b0791dda authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hda/idt - Fix power-map for speaker-pins with some HP laptops

BIOS on some HP laptops don't set the speaker-pins as fixed but expose
as jacks, and this confuses the driver as if these pins are
jack-detectable.  As a result, the machine doesn't get sounds from
speakers because the driver prepares the power-map update via jack
unsol events which never come up in reality.  The bug was introduced
in some time in 3.2 for enabling the power-mapping feature.

This patch fixes the problem by replacing the check of the persistent
power-map bits with a proper is_jack_detectable() call.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43240

Cc: <stable@vger.kernel.org> [v3.2+]
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9ea3356d
...@@ -4415,8 +4415,8 @@ static int stac92xx_init(struct hda_codec *codec) ...@@ -4415,8 +4415,8 @@ static int stac92xx_init(struct hda_codec *codec)
def_conf = get_defcfg_connect(def_conf); def_conf = get_defcfg_connect(def_conf);
/* skip any ports that don't have jacks since presence /* skip any ports that don't have jacks since presence
* detection is useless */ * detection is useless */
if (def_conf != AC_JACK_PORT_COMPLEX) { if (def_conf != AC_JACK_PORT_NONE &&
if (def_conf != AC_JACK_PORT_NONE) !is_jack_detectable(codec, nid)) {
stac_toggle_power_map(codec, nid, 1); stac_toggle_power_map(codec, nid, 1);
continue; continue;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment