Commit b205118b authored by Paul Gortmaker's avatar Paul Gortmaker

sh: don't use module_init in non-modular psw.c code

The psw.o is built for obj-y -- and hence this code is always
present.  It will never be modular, so using module_init as an alias
for __initcall can be somewhat misleading.

Fix this up now, so that we can relocate module_init from
init.h into module.h in the future.  If we don't do this, we'd
have to add module.h to obviously non-modular code, and that
would be a worse thing.

Note that direct use of __initcall is discouraged, vs. one
of the priority categorized subgroups.  As __initcall gets
mapped onto device_initcall, our use of device_initcall
directly in this change means that the runtime impact is
zero -- it will remain at level 6 in initcall ordering.
Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 1b4d5bee
...@@ -140,4 +140,4 @@ static int __init psw_init(void) ...@@ -140,4 +140,4 @@ static int __init psw_init(void)
{ {
return platform_add_devices(psw_devices, ARRAY_SIZE(psw_devices)); return platform_add_devices(psw_devices, ARRAY_SIZE(psw_devices));
} }
module_init(psw_init); device_initcall(psw_init);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment