Commit b213e0b1 authored by Alex Elder's avatar Alex Elder

rbd: fix bug in rbd_dev_id_put()

In rbd_dev_id_put(), there's a loop that's intended to determine
the maximum device id in use.  But it isn't doing that at all,
the effect of how it's written is to simply use the just-put id
number, which ignores whole purpose of this function.

Fix the bug.
Signed-off-by: default avatarAlex Elder <elder@inktank.com>
Reviewed-by: default avatarJosh Durgin <josh.durgin@inktank.com>
parent b000056a
...@@ -2680,8 +2680,8 @@ static void rbd_dev_id_put(struct rbd_device *rbd_dev) ...@@ -2680,8 +2680,8 @@ static void rbd_dev_id_put(struct rbd_device *rbd_dev)
struct rbd_device *rbd_dev; struct rbd_device *rbd_dev;
rbd_dev = list_entry(tmp, struct rbd_device, node); rbd_dev = list_entry(tmp, struct rbd_device, node);
if (rbd_id > max_id) if (rbd_dev->dev_id > max_id)
max_id = rbd_id; max_id = rbd_dev->dev_id;
} }
spin_unlock(&rbd_dev_list_lock); spin_unlock(&rbd_dev_list_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment