Commit b616230e authored by Kai Song's avatar Kai Song Committed by Michael Ellerman

powerpc/eeh: Fix docstrings in eeh.c

We fix the following warnings when building kernel with W=1:
arch/powerpc/kernel/eeh.c:598: warning: Function parameter or member 'function' not described in 'eeh_pci_enable'
arch/powerpc/kernel/eeh.c:774: warning: Function parameter or member 'edev' not described in 'eeh_set_dev_freset'
arch/powerpc/kernel/eeh.c:774: warning: expecting prototype for eeh_set_pe_freset(). Prototype was for eeh_set_dev_freset() instead
arch/powerpc/kernel/eeh.c:814: warning: Function parameter or member 'include_passed' not described in 'eeh_pe_reset_full'
arch/powerpc/kernel/eeh.c:944: warning: Function parameter or member 'ops' not described in 'eeh_init'
arch/powerpc/kernel/eeh.c:1451: warning: Function parameter or member 'include_passed' not described in 'eeh_pe_reset'
arch/powerpc/kernel/eeh.c:1526: warning: Function parameter or member 'func' not described in 'eeh_pe_inject_err'
arch/powerpc/kernel/eeh.c:1526: warning: Excess function parameter 'function' described in 'eeh_pe_inject_err'
Signed-off-by: default avatarKai Song <songkai01@inspur.com>
Reviewed-by: default avatarDaniel Axtens <dja@axtens.net>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211009041630.4135-1-songkai01@inspur.com
parent 6ffeb56e
...@@ -589,6 +589,7 @@ EXPORT_SYMBOL(eeh_check_failure); ...@@ -589,6 +589,7 @@ EXPORT_SYMBOL(eeh_check_failure);
/** /**
* eeh_pci_enable - Enable MMIO or DMA transfers for this slot * eeh_pci_enable - Enable MMIO or DMA transfers for this slot
* @pe: EEH PE * @pe: EEH PE
* @function: EEH option
* *
* This routine should be called to reenable frozen MMIO or DMA * This routine should be called to reenable frozen MMIO or DMA
* so that it would work correctly again. It's useful while doing * so that it would work correctly again. It's useful while doing
...@@ -761,8 +762,8 @@ int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state stat ...@@ -761,8 +762,8 @@ int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state stat
} }
/** /**
* eeh_set_pe_freset - Check the required reset for the indicated device * eeh_set_dev_freset - Check the required reset for the indicated device
* @data: EEH device * @edev: EEH device
* @flag: return value * @flag: return value
* *
* Each device might have its preferred reset type: fundamental or * Each device might have its preferred reset type: fundamental or
...@@ -801,6 +802,7 @@ static void eeh_pe_refreeze_passed(struct eeh_pe *root) ...@@ -801,6 +802,7 @@ static void eeh_pe_refreeze_passed(struct eeh_pe *root)
/** /**
* eeh_pe_reset_full - Complete a full reset process on the indicated PE * eeh_pe_reset_full - Complete a full reset process on the indicated PE
* @pe: EEH PE * @pe: EEH PE
* @include_passed: include passed-through devices?
* *
* This function executes a full reset procedure on a PE, including setting * This function executes a full reset procedure on a PE, including setting
* the appropriate flags, performing a fundamental or hot reset, and then * the appropriate flags, performing a fundamental or hot reset, and then
...@@ -937,6 +939,7 @@ static struct notifier_block eeh_device_nb = { ...@@ -937,6 +939,7 @@ static struct notifier_block eeh_device_nb = {
/** /**
* eeh_init - System wide EEH initialization * eeh_init - System wide EEH initialization
* @ops: struct to trace EEH operation callback functions
* *
* It's the platform's job to call this from an arch_initcall(). * It's the platform's job to call this from an arch_initcall().
*/ */
...@@ -1442,6 +1445,7 @@ static int eeh_pe_reenable_devices(struct eeh_pe *pe, bool include_passed) ...@@ -1442,6 +1445,7 @@ static int eeh_pe_reenable_devices(struct eeh_pe *pe, bool include_passed)
* eeh_pe_reset - Issue PE reset according to specified type * eeh_pe_reset - Issue PE reset according to specified type
* @pe: EEH PE * @pe: EEH PE
* @option: reset type * @option: reset type
* @include_passed: include passed-through devices?
* *
* The routine is called to reset the specified PE with the * The routine is called to reset the specified PE with the
* indicated type, either fundamental reset or hot reset. * indicated type, either fundamental reset or hot reset.
...@@ -1513,12 +1517,12 @@ EXPORT_SYMBOL_GPL(eeh_pe_configure); ...@@ -1513,12 +1517,12 @@ EXPORT_SYMBOL_GPL(eeh_pe_configure);
* eeh_pe_inject_err - Injecting the specified PCI error to the indicated PE * eeh_pe_inject_err - Injecting the specified PCI error to the indicated PE
* @pe: the indicated PE * @pe: the indicated PE
* @type: error type * @type: error type
* @function: error function * @func: error function
* @addr: address * @addr: address
* @mask: address mask * @mask: address mask
* *
* The routine is called to inject the specified PCI error, which * The routine is called to inject the specified PCI error, which
* is determined by @type and @function, to the indicated PE for * is determined by @type and @func, to the indicated PE for
* testing purpose. * testing purpose.
*/ */
int eeh_pe_inject_err(struct eeh_pe *pe, int type, int func, int eeh_pe_inject_err(struct eeh_pe *pe, int type, int func,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment