Commit b68231a1 authored by Wei Yongjun's avatar Wei Yongjun Committed by Mauro Carvalho Chehab

[media] v4l: ti-vpe: fix return value check in vpe_probe()

In case of error, the function devm_kzalloc() and devm_ioremap()
returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return
value check should be replaced with NULL test.
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: default avatarArchit Taneja <archit@ti.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 6676cafe
...@@ -1942,8 +1942,8 @@ static int vpe_probe(struct platform_device *pdev) ...@@ -1942,8 +1942,8 @@ static int vpe_probe(struct platform_device *pdev)
int ret, irq, func; int ret, irq, func;
dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
if (IS_ERR(dev)) if (!dev)
return PTR_ERR(dev); return -ENOMEM;
spin_lock_init(&dev->lock); spin_lock_init(&dev->lock);
...@@ -1962,8 +1962,8 @@ static int vpe_probe(struct platform_device *pdev) ...@@ -1962,8 +1962,8 @@ static int vpe_probe(struct platform_device *pdev)
* registers based on the sub block base addresses * registers based on the sub block base addresses
*/ */
dev->base = devm_ioremap(&pdev->dev, res->start, SZ_32K); dev->base = devm_ioremap(&pdev->dev, res->start, SZ_32K);
if (IS_ERR(dev->base)) { if (!dev->base) {
ret = PTR_ERR(dev->base); ret = -ENOMEM;
goto v4l2_dev_unreg; goto v4l2_dev_unreg;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment