Commit b8203ec7 authored by Yang Li's avatar Yang Li Committed by Vinod Koul

phy: ti: Fix an error code in wiz_probe()

When the code execute this if statement, the value of ret is 0.
However, we can see from the dev_err() log that the value of
ret should be -EINVAL.

Clean up smatch warning:

drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code 'ret'
Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Fixes: c9f9eba0 ("phy: ti: j721e-wiz: Manage typec-gpio-dir")
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1621939832-65535-1-git-send-email-yang.lee@linux.alibaba.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent aaac9a1b
...@@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev) ...@@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev)
if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN || if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN ||
wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) { wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) {
ret = -EINVAL;
dev_err(dev, "Invalid typec-dir-debounce property\n"); dev_err(dev, "Invalid typec-dir-debounce property\n");
goto err_addr_to_resource; goto err_addr_to_resource;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment