Commit b8dbc324 authored by Joe Perches's avatar Joe Perches Committed by Eric Paris

audit: Use hex_byte_pack_upper

Using the generic kernel function causes the
object size to increase with gcc 4.8.1.

$ size kernel/audit.o*
   text	   data	    bss	    dec	    hex	filename
  18577	   6079	   8436	  33092	   8144	kernel/audit.o.new
  18579	   6015	   8420	  33014	   80f6	kernel/audit.o.old

Unsigned...
parent 06bdadd7
...@@ -1466,7 +1466,6 @@ void audit_log_n_hex(struct audit_buffer *ab, const unsigned char *buf, ...@@ -1466,7 +1466,6 @@ void audit_log_n_hex(struct audit_buffer *ab, const unsigned char *buf,
int i, avail, new_len; int i, avail, new_len;
unsigned char *ptr; unsigned char *ptr;
struct sk_buff *skb; struct sk_buff *skb;
static const unsigned char *hex = "0123456789ABCDEF";
if (!ab) if (!ab)
return; return;
...@@ -1484,10 +1483,8 @@ void audit_log_n_hex(struct audit_buffer *ab, const unsigned char *buf, ...@@ -1484,10 +1483,8 @@ void audit_log_n_hex(struct audit_buffer *ab, const unsigned char *buf,
} }
ptr = skb_tail_pointer(skb); ptr = skb_tail_pointer(skb);
for (i=0; i<len; i++) { for (i = 0; i < len; i++)
*ptr++ = hex[(buf[i] & 0xF0)>>4]; /* Upper nibble */ ptr = hex_byte_pack_upper(ptr, buf[i]);
*ptr++ = hex[buf[i] & 0x0F]; /* Lower nibble */
}
*ptr = 0; *ptr = 0;
skb_put(skb, len << 1); /* new string is twice the old string */ skb_put(skb, len << 1); /* new string is twice the old string */
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment