Commit bbe1c274 authored by Mathias Krause's avatar Mathias Krause Committed by Jani Nikula

drm/i915: Remove bogus __init annotation from DMI callbacks

The __init annotations for the DMI callback functions are wrong as this
code can be called even after the module has been initialized, e.g. like
this:

  # echo 1 > /sys/bus/pci/devices/0000:00:02.0/remove
  # modprobe i915
  # echo 1 > /sys/bus/pci/rescan

The first command will remove the PCI device from the kernel's device
list so the second command won't see it right away. But as it registers
a PCI driver it'll see it on the third command. If the system happens to
match one of the DMI table entries we'll try to call a function in long
released memory and generate an Oops, at best.

Fix this by removing the bogus annotation.

Modpost should have caught that one but it ignores section reference
mismatches from the .rodata section. :/

Fixes: 25e341cf ("drm/i915: quirk away broken OpRegion VBT")
Fixes: 8ca4013d ("CHROMIUM: i915: Add DMI override to skip CRT...")
Fixes: 425d244c ("drm/i915: ignore LVDS on intel graphics systems...")
Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Duncan Laurie <dlaurie@chromium.org>
Cc: Jarod Wilson <jarod@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>	# Can modpost be fixed?
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 813008cd
...@@ -1123,7 +1123,7 @@ init_vbt_defaults(struct drm_i915_private *dev_priv) ...@@ -1123,7 +1123,7 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
} }
} }
static int __init intel_no_opregion_vbt_callback(const struct dmi_system_id *id) static int intel_no_opregion_vbt_callback(const struct dmi_system_id *id)
{ {
DRM_DEBUG_KMS("Falling back to manually reading VBT from " DRM_DEBUG_KMS("Falling back to manually reading VBT from "
"VBIOS ROM for %s\n", "VBIOS ROM for %s\n",
......
...@@ -804,7 +804,7 @@ static const struct drm_encoder_funcs intel_crt_enc_funcs = { ...@@ -804,7 +804,7 @@ static const struct drm_encoder_funcs intel_crt_enc_funcs = {
.destroy = intel_encoder_destroy, .destroy = intel_encoder_destroy,
}; };
static int __init intel_no_crt_dmi_callback(const struct dmi_system_id *id) static int intel_no_crt_dmi_callback(const struct dmi_system_id *id)
{ {
DRM_INFO("Skipping CRT initialization for %s\n", id->ident); DRM_INFO("Skipping CRT initialization for %s\n", id->ident);
return 1; return 1;
......
...@@ -538,7 +538,7 @@ static const struct drm_encoder_funcs intel_lvds_enc_funcs = { ...@@ -538,7 +538,7 @@ static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
.destroy = intel_encoder_destroy, .destroy = intel_encoder_destroy,
}; };
static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id) static int intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
{ {
DRM_INFO("Skipping LVDS initialization for %s\n", id->ident); DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
return 1; return 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment