Commit bc18546b authored by Dan Carpenter's avatar Dan Carpenter Committed by Theodore Ts'o

ext4: fix an IS_ERR() vs NULL check

The ext4_find_extent() function never returns NULL, it returns error
pointers.

Fixes: 44059e503b03 ("ext4: fast commit recovery path")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20201023112232.GB282278@mwandaSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
parent c9200760
...@@ -5815,8 +5815,8 @@ int ext4_ext_replay_update_ex(struct inode *inode, ext4_lblk_t start, ...@@ -5815,8 +5815,8 @@ int ext4_ext_replay_update_ex(struct inode *inode, ext4_lblk_t start,
int ret; int ret;
path = ext4_find_extent(inode, start, NULL, 0); path = ext4_find_extent(inode, start, NULL, 0);
if (!path) if (IS_ERR(path))
return -EINVAL; return PTR_ERR(path);
ex = path[path->p_depth].p_ext; ex = path[path->p_depth].p_ext;
if (!ex) { if (!ex) {
ret = -EFSCORRUPTED; ret = -EFSCORRUPTED;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment