Commit be3e477e authored by Carsten Haitzler's avatar Carsten Haitzler Committed by Liviu Dudau

drm/komeda: Fix bit check to import to value of proper type

KASAN found this problem. find_first_bit() expects to look at a
pointer pointing to a long, but we look at a u32 - this is going to be
an issue with endianness but, KSAN already flags this as out-of-bounds
stack reads. This fixes it by just importing inot a local long.
Signed-off-by: default avatarCarsten Haitzler <carsten.haitzler@arm.com>
Acked-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Signed-off-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201218150812.68195-1-carsten.haitzler@foss.arm.com
parent a24cf238
...@@ -137,9 +137,10 @@ komeda_pipeline_get_first_component(struct komeda_pipeline *pipe, ...@@ -137,9 +137,10 @@ komeda_pipeline_get_first_component(struct komeda_pipeline *pipe,
u32 comp_mask) u32 comp_mask)
{ {
struct komeda_component *c = NULL; struct komeda_component *c = NULL;
unsigned long comp_mask_local = (unsigned long)comp_mask;
int id; int id;
id = find_first_bit((unsigned long *)&comp_mask, 32); id = find_first_bit(&comp_mask_local, 32);
if (id < 32) if (id < 32)
c = komeda_pipeline_get_component(pipe, id); c = komeda_pipeline_get_component(pipe, id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment