Commit bebc3bbf authored by Yajun Deng's avatar Yajun Deng Committed by Jakub Kicinski

net: decnet: Fix refcount warning for new dn_fib_info

fib_treeref needs to be set after kzalloc. The old code had a ++ which
led to the confusion when the int was replaced by a refcount_t.

Fixes: 79976892 ("net: convert fib_treeref from int to refcount_t")
Signed-off-by: default avatarYajun Deng <yajun.deng@linux.dev>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20210803073739.22339-1-yajun.deng@linux.devSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c8f6c77d
...@@ -389,7 +389,7 @@ struct dn_fib_info *dn_fib_create_info(const struct rtmsg *r, struct nlattr *att ...@@ -389,7 +389,7 @@ struct dn_fib_info *dn_fib_create_info(const struct rtmsg *r, struct nlattr *att
return ofi; return ofi;
} }
refcount_inc(&fi->fib_treeref); refcount_set(&fi->fib_treeref, 1);
refcount_set(&fi->fib_clntref, 1); refcount_set(&fi->fib_clntref, 1);
spin_lock(&dn_fib_info_lock); spin_lock(&dn_fib_info_lock);
fi->fib_next = dn_fib_info_list; fi->fib_next = dn_fib_info_list;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment