Commit c21709e7 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net: phy: dp83869: fix return of uninitialized variable ret

In the case where the call to phy_interface_is_rgmii returns zero
the variable ret is left uninitialized and this is returned at
the end of the function dp83869_configure_rgmii.  Fix this by
returning 0 instead of the uninitialized value in ret.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 01db923e ("net: phy: dp83869: Add TI dp83869 phy")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3132174b
...@@ -239,7 +239,7 @@ static int dp83869_configure_rgmii(struct phy_device *phydev, ...@@ -239,7 +239,7 @@ static int dp83869_configure_rgmii(struct phy_device *phydev,
dp83869->io_impedance & dp83869->io_impedance &
DP83869_IO_MUX_CFG_IO_IMPEDANCE_CTRL); DP83869_IO_MUX_CFG_IO_IMPEDANCE_CTRL);
return ret; return 0;
} }
static int dp83869_configure_mode(struct phy_device *phydev, static int dp83869_configure_mode(struct phy_device *phydev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment