Commit c2654518 authored by Dominik Brodowski's avatar Dominik Brodowski Committed by Linus Torvalds

[PATCH] cpufreq: longhaul cleanup

Clean up searching code for best frequency and add some safety checks.
parent 123c66ee
...@@ -313,6 +313,10 @@ static void longhaul_setstate (unsigned int clock_ratio_index, unsigned int newf ...@@ -313,6 +313,10 @@ static void longhaul_setstate (unsigned int clock_ratio_index, unsigned int newf
if ((!can_scale_fsb) && (newfsb != current_fsb)) if ((!can_scale_fsb) && (newfsb != current_fsb))
return; return;
if (((clock_ratio[clock_ratio_index] * newfsb * 100) > highest_speed) ||
((clock_ratio[clock_ratio_index] * newfsb * 100) < lowest_speed))
return;
freqs.old = longhaul_get_cpu_mult() * longhaul_get_cpu_fsb() * 100; freqs.old = longhaul_get_cpu_mult() * longhaul_get_cpu_fsb() * 100;
freqs.new = clock_ratio[clock_ratio_index] * newfsb * 100; freqs.new = clock_ratio[clock_ratio_index] * newfsb * 100;
freqs.cpu = 0; /* longhaul.c is UP only driver */ freqs.cpu = 0; /* longhaul.c is UP only driver */
...@@ -582,18 +586,68 @@ static int longhaul_verify(struct cpufreq_policy *policy) ...@@ -582,18 +586,68 @@ static int longhaul_verify(struct cpufreq_policy *policy)
policy->max = newmax; policy->max = newmax;
cpufreq_verify_within_limits(policy, lowest_speed, highest_speed);
return 0;
}
static int longhaul_get_best_freq_for_fsb(struct cpufreq_policy *policy,
unsigned int min_mult,
unsigned int max_mult,
unsigned int fsb,
unsigned int *new_mult)
{
unsigned int optimal = 0;
unsigned int found_optimal = 0;
unsigned int i;
switch(policy->policy) {
case CPUFREQ_POLICY_POWERSAVE:
optimal = max_mult;
break;
case CPUFREQ_POLICY_PERFORMANCE:
optimal = min_mult;
}
for(i=0; i<numscales; i++) {
unsigned int freq = fsb * clock_ratio[i] * 100;
if ((freq > policy->max) ||
(freq < policy->min))
continue;
switch(policy->policy) {
case CPUFREQ_POLICY_POWERSAVE:
if (clock_ratio[i] < clock_ratio[optimal]) {
found_optimal = 1;
optimal = i;
}
break;
case CPUFREQ_POLICY_PERFORMANCE:
if (clock_ratio[i] > clock_ratio[optimal]) {
found_optimal = 1;
optimal = i;
}
break;
}
}
if (found_optimal) {
*new_mult = optimal;
return 1;
}
return 0; return 0;
} }
static int longhaul_setpolicy (struct cpufreq_policy *policy) static int longhaul_setpolicy (struct cpufreq_policy *policy)
{ {
unsigned int number_states = 0;
unsigned int i; unsigned int i;
unsigned int fsb_index = 0; unsigned int fsb_index = 0;
unsigned int new_fsb = 0; unsigned int new_fsb = 0;
unsigned int new_clock_ratio = 0; unsigned int new_clock_ratio = 0;
unsigned int best_freq = -1; unsigned int min_mult = 0;
unsigned int max_mult = 0;
if (!longhaul_driver) if (!longhaul_driver)
return -EINVAL; return -EINVAL;
...@@ -603,103 +657,36 @@ static int longhaul_setpolicy (struct cpufreq_policy *policy) ...@@ -603,103 +657,36 @@ static int longhaul_setpolicy (struct cpufreq_policy *policy)
else else
fsb_search_table = power_fsb_table; fsb_search_table = power_fsb_table;
if (can_scale_fsb==1) { for(i=0;i<numscales;i++) {
for (fsb_index=0; fsb_search_table[fsb_index]!=-1; fsb_index++) if (clock_ratio[max_mult] < clock_ratio[i])
{ max_mult = i;
unsigned int tmpcount = longhaul_statecount_fsb(policy, fsb_search_table[fsb_index]); else if (clock_ratio[min_mult] > clock_ratio[i])
if (tmpcount == 1) min_mult = i;
new_fsb = fsb_search_table[fsb_index];
number_states += tmpcount;
}
} else {
number_states = longhaul_statecount_fsb(policy, current_fsb);
new_fsb = current_fsb;
} }
if (!number_states)
return -EINVAL;
else if (number_states == 1) {
for(i=0; i<numscales; i++) {
if ((clock_ratio[i] != -1) &&
((clock_ratio[i] * new_fsb * 100) <= policy->max) &&
((clock_ratio[i] * new_fsb * 100) >= policy->min))
new_clock_ratio = i;
}
longhaul_setstate(new_clock_ratio, new_fsb);
}
switch (policy->policy) {
case CPUFREQ_POLICY_POWERSAVE:
best_freq = -1;
if (can_scale_fsb==1) { if (can_scale_fsb==1) {
unsigned int found = 0;
for (fsb_index=0; fsb_search_table[fsb_index]!=-1; fsb_index++) for (fsb_index=0; fsb_search_table[fsb_index]!=-1; fsb_index++)
{ {
for(i=0; i<numscales; i++) { if (longhaul_get_best_freq_for_fsb(policy,
unsigned int tmpfreq = fsb_search_table[fsb_index] * clock_ratio[i] * 100; min_mult, max_mult,
if (clock_ratio[i] == -1) fsb_search_table[fsb_index],
continue; &new_clock_ratio)) {
if ((tmpfreq >= policy->min) &&
(tmpfreq <= policy->max) &&
(tmpfreq < best_freq)) {
new_clock_ratio = i;
new_fsb = fsb_search_table[fsb_index]; new_fsb = fsb_search_table[fsb_index];
}
}
}
} else {
for(i=0; i<numscales; i++) {
unsigned int tmpfreq = current_fsb * clock_ratio[i] * 100;
if (clock_ratio[i] == -1)
continue;
if ((tmpfreq >= policy->min) &&
(tmpfreq <= policy->max) &&
(tmpfreq < best_freq)) {
new_clock_ratio = i;
new_fsb = current_fsb;
}
}
}
break; break;
case CPUFREQ_POLICY_PERFORMANCE:
best_freq = 0;
if (can_scale_fsb==1) {
for (fsb_index=0; fsb_search_table[fsb_index]!=-1; fsb_index++)
{
for(i=0; i<numscales; i++) {
unsigned int tmpfreq = fsb_search_table[fsb_index] * clock_ratio[i] * 100;
if (clock_ratio[i] == -1)
continue;
if ((tmpfreq >= policy->min) &&
(tmpfreq <= policy->max) &&
(tmpfreq > best_freq)) {
new_clock_ratio = i;
new_fsb = fsb_search_table[fsb_index];
}
} }
} }
if (!found)
return -EINVAL;
} else { } else {
for(i=0; i<numscales; i++) {
unsigned int tmpfreq = current_fsb * clock_ratio[i] * 100;
if (clock_ratio[i] == -1)
continue;
if ((tmpfreq >= policy->min) &&
(tmpfreq <= policy->max) &&
(tmpfreq > best_freq)) {
new_clock_ratio = i;
new_fsb = current_fsb; new_fsb = current_fsb;
} if (!longhaul_get_best_freq_for_fsb(policy, min_mult,
} max_mult, new_fsb, &new_clock_ratio))
}
break;
default:
return -EINVAL; return -EINVAL;
} }
longhaul_setstate(new_clock_ratio, new_fsb); longhaul_setstate(new_clock_ratio, new_fsb);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment