Commit c2c6325e authored by Jiri Pirko's avatar Jiri Pirko Committed by Michael S. Tsirkin

virtio_net: convert to use virtio_find_vqs_info()

Instead of passing separate names and callbacks arrays
to virtio_find_vqs_ctx(), allocate one of virtual_queue_info structs
and pass it to virtio_find_vqs_info().
Suggested-by: default avatarXuan Zhuo <xuanzhuo@linux.alibaba.com>
Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Message-Id: <20240708074814.1739223-14-jiri@resnulli.us>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 210a70f2
...@@ -5293,9 +5293,8 @@ static unsigned int mergeable_min_buf_len(struct virtnet_info *vi, struct virtqu ...@@ -5293,9 +5293,8 @@ static unsigned int mergeable_min_buf_len(struct virtnet_info *vi, struct virtqu
static int virtnet_find_vqs(struct virtnet_info *vi) static int virtnet_find_vqs(struct virtnet_info *vi)
{ {
vq_callback_t **callbacks; struct virtqueue_info *vqs_info;
struct virtqueue **vqs; struct virtqueue **vqs;
const char **names;
int ret = -ENOMEM; int ret = -ENOMEM;
int total_vqs; int total_vqs;
bool *ctx; bool *ctx;
...@@ -5312,12 +5311,9 @@ static int virtnet_find_vqs(struct virtnet_info *vi) ...@@ -5312,12 +5311,9 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
vqs = kcalloc(total_vqs, sizeof(*vqs), GFP_KERNEL); vqs = kcalloc(total_vqs, sizeof(*vqs), GFP_KERNEL);
if (!vqs) if (!vqs)
goto err_vq; goto err_vq;
callbacks = kmalloc_array(total_vqs, sizeof(*callbacks), GFP_KERNEL); vqs_info = kcalloc(total_vqs, sizeof(*vqs_info), GFP_KERNEL);
if (!callbacks) if (!vqs_info)
goto err_callback; goto err_vqs_info;
names = kmalloc_array(total_vqs, sizeof(*names), GFP_KERNEL);
if (!names)
goto err_names;
if (!vi->big_packets || vi->mergeable_rx_bufs) { if (!vi->big_packets || vi->mergeable_rx_bufs) {
ctx = kcalloc(total_vqs, sizeof(*ctx), GFP_KERNEL); ctx = kcalloc(total_vqs, sizeof(*ctx), GFP_KERNEL);
if (!ctx) if (!ctx)
...@@ -5328,24 +5324,22 @@ static int virtnet_find_vqs(struct virtnet_info *vi) ...@@ -5328,24 +5324,22 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
/* Parameters for control virtqueue, if any */ /* Parameters for control virtqueue, if any */
if (vi->has_cvq) { if (vi->has_cvq) {
callbacks[total_vqs - 1] = NULL; vqs_info[total_vqs - 1].name = "control";
names[total_vqs - 1] = "control";
} }
/* Allocate/initialize parameters for send/receive virtqueues */ /* Allocate/initialize parameters for send/receive virtqueues */
for (i = 0; i < vi->max_queue_pairs; i++) { for (i = 0; i < vi->max_queue_pairs; i++) {
callbacks[rxq2vq(i)] = skb_recv_done; vqs_info[rxq2vq(i)].callback = skb_recv_done;
callbacks[txq2vq(i)] = skb_xmit_done; vqs_info[txq2vq(i)].callback = skb_xmit_done;
sprintf(vi->rq[i].name, "input.%u", i); sprintf(vi->rq[i].name, "input.%u", i);
sprintf(vi->sq[i].name, "output.%u", i); sprintf(vi->sq[i].name, "output.%u", i);
names[rxq2vq(i)] = vi->rq[i].name; vqs_info[rxq2vq(i)].name = vi->rq[i].name;
names[txq2vq(i)] = vi->sq[i].name; vqs_info[txq2vq(i)].name = vi->sq[i].name;
if (ctx) if (ctx)
ctx[rxq2vq(i)] = true; vqs_info[rxq2vq(i)].ctx = true;
} }
ret = virtio_find_vqs_ctx(vi->vdev, total_vqs, vqs, callbacks, ret = virtio_find_vqs_info(vi->vdev, total_vqs, vqs, vqs_info, NULL);
names, ctx, NULL);
if (ret) if (ret)
goto err_find; goto err_find;
...@@ -5367,10 +5361,8 @@ static int virtnet_find_vqs(struct virtnet_info *vi) ...@@ -5367,10 +5361,8 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
err_find: err_find:
kfree(ctx); kfree(ctx);
err_ctx: err_ctx:
kfree(names); kfree(vqs_info);
err_names: err_vqs_info:
kfree(callbacks);
err_callback:
kfree(vqs); kfree(vqs);
err_vq: err_vq:
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment