Commit c3acd590 authored by Felipe Balbi's avatar Felipe Balbi

usb: dwc3: gadget: use num_trbs when skipping TRBs on ->dequeue()

Now that we track how many TRBs a request uses, it's easier to skip
over them in case of a call to usb_ep_dequeue(). Let's do so and
simplify the code a bit.
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 09fe1f8d
...@@ -1502,6 +1502,8 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep, ...@@ -1502,6 +1502,8 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
break; break;
} }
if (r == req) { if (r == req) {
int i;
/* wait until it is processed */ /* wait until it is processed */
dwc3_stop_active_transfer(dep, true); dwc3_stop_active_transfer(dep, true);
...@@ -1539,33 +1541,13 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep, ...@@ -1539,33 +1541,13 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
if (!r->trb) if (!r->trb)
goto out0; goto out0;
if (r->num_pending_sgs) { for (i = 0; i < r->num_trbs; i++) {
struct dwc3_trb *trb; struct dwc3_trb *trb;
int i = 0;
for (i = 0; i < r->num_pending_sgs; i++) {
trb = r->trb + i; trb = r->trb + i;
trb->ctrl &= ~DWC3_TRB_CTRL_HWO; trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
dwc3_ep_inc_deq(dep); dwc3_ep_inc_deq(dep);
} }
if (r->needs_extra_trb) {
trb = r->trb + r->num_pending_sgs + 1;
trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
dwc3_ep_inc_deq(dep);
}
} else {
struct dwc3_trb *trb = r->trb;
trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
dwc3_ep_inc_deq(dep);
if (r->needs_extra_trb) {
trb = r->trb + 1;
trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
dwc3_ep_inc_deq(dep);
}
}
goto out1; goto out1;
} }
dev_err(dwc->dev, "request %pK was not queued to %s\n", dev_err(dwc->dev, "request %pK was not queued to %s\n",
...@@ -1575,8 +1557,6 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep, ...@@ -1575,8 +1557,6 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
} }
out1: out1:
/* giveback the request */
dwc3_gadget_giveback(dep, req, -ECONNRESET); dwc3_gadget_giveback(dep, req, -ECONNRESET);
out0: out0:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment