Commit c4ff41b9 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Herbert Xu

hwrng: ingenic - Fix a resource leak in an error handling path

In case of error, we should call 'clk_disable_unprepare()' to undo a
previous 'clk_prepare_enable()' call, as already done in the remove
function.

Fixes: 406346d2 ("hwrng: ingenic - Add hardware TRNG for Ingenic X1830")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: default avatar周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 256693a3
...@@ -113,13 +113,17 @@ static int ingenic_trng_probe(struct platform_device *pdev) ...@@ -113,13 +113,17 @@ static int ingenic_trng_probe(struct platform_device *pdev)
ret = hwrng_register(&trng->rng); ret = hwrng_register(&trng->rng);
if (ret) { if (ret) {
dev_err(&pdev->dev, "Failed to register hwrng\n"); dev_err(&pdev->dev, "Failed to register hwrng\n");
return ret; goto err_unprepare_clk;
} }
platform_set_drvdata(pdev, trng); platform_set_drvdata(pdev, trng);
dev_info(&pdev->dev, "Ingenic DTRNG driver registered\n"); dev_info(&pdev->dev, "Ingenic DTRNG driver registered\n");
return 0; return 0;
err_unprepare_clk:
clk_disable_unprepare(trng->clk);
return ret;
} }
static int ingenic_trng_remove(struct platform_device *pdev) static int ingenic_trng_remove(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment