Commit c5dcfaac authored by Bart Van Assche's avatar Bart Van Assche Committed by James Bottomley

[SCSI] qla2xxx: Remove two superfluous tests.

Since ha->model_desc is an array comparing it against NULL is
superfluous. Hence remove these tests.
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarSaurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 6593d5bd
...@@ -1370,7 +1370,6 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha) ...@@ -1370,7 +1370,6 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha)
/* Model description. */ /* Model description. */
eiter = (struct ct_fdmi_hba_attr *) (entries + size); eiter = (struct ct_fdmi_hba_attr *) (entries + size);
eiter->type = __constant_cpu_to_be16(FDMI_HBA_MODEL_DESCRIPTION); eiter->type = __constant_cpu_to_be16(FDMI_HBA_MODEL_DESCRIPTION);
if (ha->model_desc)
strncpy(eiter->a.model_desc, ha->model_desc, 80); strncpy(eiter->a.model_desc, ha->model_desc, 80);
alen = strlen(eiter->a.model_desc); alen = strlen(eiter->a.model_desc);
alen += (alen & 3) ? (4 - (alen & 3)) : 4; alen += (alen & 3) ? (4 - (alen & 3)) : 4;
......
...@@ -2839,8 +2839,7 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) ...@@ -2839,8 +2839,7 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
qla2x00_dfs_setup(base_vha); qla2x00_dfs_setup(base_vha);
ql_log(ql_log_info, base_vha, 0x00fb, ql_log(ql_log_info, base_vha, 0x00fb,
"QLogic %s - %s.\n", "QLogic %s - %s.\n", ha->model_number, ha->model_desc);
ha->model_number, ha->model_desc ? ha->model_desc : "");
ql_log(ql_log_info, base_vha, 0x00fc, ql_log(ql_log_info, base_vha, 0x00fc,
"ISP%04X: %s @ %s hdma%c host#=%ld fw=%s.\n", "ISP%04X: %s @ %s hdma%c host#=%ld fw=%s.\n",
pdev->device, ha->isp_ops->pci_info_str(base_vha, pci_info), pdev->device, ha->isp_ops->pci_info_str(base_vha, pci_info),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment