Commit c6a297bc authored by Kristina Martšenko's avatar Kristina Martšenko Committed by Greg Kroah-Hartman

staging: sbe-2t3e3: remove t3e3_stats_t typedef

Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_stats_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:107: WARNING: do not add new typedefs
Signed-off-by: default avatarKristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 154d2b8c
...@@ -701,7 +701,7 @@ struct channel { ...@@ -701,7 +701,7 @@ struct channel {
} h; } h;
/* statistics */ /* statistics */
t3e3_stats_t s; struct t3e3_stats s;
/* running */ /* running */
struct { struct {
......
...@@ -216,8 +216,7 @@ static void t3e3_port_set(struct channel *sc, struct t3e3_param *param) ...@@ -216,8 +216,7 @@ static void t3e3_port_set(struct channel *sc, struct t3e3_param *param)
cpld_set_scrambler(sc, param->scrambler); cpld_set_scrambler(sc, param->scrambler);
} }
static void t3e3_port_get_stats(struct channel *sc, static void t3e3_port_get_stats(struct channel *sc, struct t3e3_stats *stats)
t3e3_stats_t *stats)
{ {
u32 result; u32 result;
...@@ -279,12 +278,12 @@ static void t3e3_port_get_stats(struct channel *sc, ...@@ -279,12 +278,12 @@ static void t3e3_port_get_stats(struct channel *sc,
result += exar7250_read(sc, SBE_2T3E3_FRAMER_REG_PMON_HOLDING_REGISTER); result += exar7250_read(sc, SBE_2T3E3_FRAMER_REG_PMON_HOLDING_REGISTER);
sc->s.CP_BIT += result; sc->s.CP_BIT += result;
memcpy(stats, &(sc->s), sizeof(t3e3_stats_t)); memcpy(stats, &(sc->s), sizeof(struct t3e3_stats));
} }
static void t3e3_port_del_stats(struct channel *sc) static void t3e3_port_del_stats(struct channel *sc)
{ {
memset(&(sc->s), 0, sizeof(t3e3_stats_t)); memset(&(sc->s), 0, sizeof(struct t3e3_stats));
} }
void t3e3_if_config(struct channel *sc, u32 cmd, char *set, void t3e3_if_config(struct channel *sc, u32 cmd, char *set,
......
...@@ -104,7 +104,7 @@ struct t3e3_param { ...@@ -104,7 +104,7 @@ struct t3e3_param {
u_int8_t bandwidth_stop; /* 0-255 */ u_int8_t bandwidth_stop; /* 0-255 */
}; };
typedef struct t3e3_stats { struct t3e3_stats {
u_int64_t in_bytes; u_int64_t in_bytes;
u32 in_packets, in_dropped; u32 in_packets, in_dropped;
u32 in_errors, in_error_desc, in_error_coll, in_error_drib, u32 in_errors, in_error_desc, in_error_coll, in_error_drib,
...@@ -117,13 +117,13 @@ typedef struct t3e3_stats { ...@@ -117,13 +117,13 @@ typedef struct t3e3_stats {
u_int8_t LOC, LOF, OOF, LOS, AIS, FERF, IDLE, AIC, FEAC; u_int8_t LOC, LOF, OOF, LOS, AIS, FERF, IDLE, AIC, FEAC;
u_int16_t FEBE_code; u_int16_t FEBE_code;
u32 LCV, FRAMING_BIT, PARITY_ERROR, FEBE_count, CP_BIT; u32 LCV, FRAMING_BIT, PARITY_ERROR, FEBE_count, CP_BIT;
} t3e3_stats_t; };
typedef struct t3e3_resp { typedef struct t3e3_resp {
union { union {
struct t3e3_param param; struct t3e3_param param;
t3e3_stats_t stats; struct t3e3_stats stats;
u32 data; u32 data;
} u; } u;
} t3e3_resp_t; } t3e3_resp_t;
......
...@@ -61,7 +61,7 @@ static struct net_device_stats *t3e3_get_stats(struct net_device *dev) ...@@ -61,7 +61,7 @@ static struct net_device_stats *t3e3_get_stats(struct net_device *dev)
{ {
struct net_device_stats *nstats = &dev->stats; struct net_device_stats *nstats = &dev->stats;
struct channel *sc = dev_to_priv(dev); struct channel *sc = dev_to_priv(dev);
t3e3_stats_t *stats = &sc->s; struct t3e3_stats *stats = &sc->s;
memset(nstats, 0, sizeof(struct net_device_stats)); memset(nstats, 0, sizeof(struct net_device_stats));
nstats->rx_packets = stats->in_packets; nstats->rx_packets = stats->in_packets;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment