Commit c7097e0f authored by Dave Jones's avatar Dave Jones Committed by Linus Torvalds

[PATCH] CodingStyle fixes for drm_agpsupport

parent e85d2109
...@@ -105,7 +105,8 @@ int DRM(agp_acquire)(struct inode *inode, struct file *filp, ...@@ -105,7 +105,8 @@ int DRM(agp_acquire)(struct inode *inode, struct file *filp,
if (!dev->agp || dev->agp->acquired || !drm_agp->acquire) if (!dev->agp || dev->agp->acquired || !drm_agp->acquire)
return -EINVAL; return -EINVAL;
if ((retcode = drm_agp->acquire())) return retcode; if ((retcode = drm_agp->acquire()))
return retcode;
dev->agp->acquired = 1; dev->agp->acquired = 1;
return 0; return 0;
} }
...@@ -142,7 +143,8 @@ int DRM(agp_release)(struct inode *inode, struct file *filp, ...@@ -142,7 +143,8 @@ int DRM(agp_release)(struct inode *inode, struct file *filp,
*/ */
void DRM(agp_do_release)(void) void DRM(agp_do_release)(void)
{ {
if (drm_agp->release) drm_agp->release(); if (drm_agp->release)
drm_agp->release();
} }
/** /**
...@@ -200,7 +202,8 @@ int DRM(agp_alloc)(struct inode *inode, struct file *filp, ...@@ -200,7 +202,8 @@ int DRM(agp_alloc)(struct inode *inode, struct file *filp,
unsigned long pages; unsigned long pages;
u32 type; u32 type;
if (!dev->agp || !dev->agp->acquired) return -EINVAL; if (!dev->agp || !dev->agp->acquired)
return -EINVAL;
if (copy_from_user(&request, (drm_agp_buffer_t *)arg, sizeof(request))) if (copy_from_user(&request, (drm_agp_buffer_t *)arg, sizeof(request)))
return -EFAULT; return -EFAULT;
if (!(entry = DRM(alloc)(sizeof(*entry), DRM_MEM_AGPLISTS))) if (!(entry = DRM(alloc)(sizeof(*entry), DRM_MEM_AGPLISTS)))
...@@ -222,7 +225,8 @@ int DRM(agp_alloc)(struct inode *inode, struct file *filp, ...@@ -222,7 +225,8 @@ int DRM(agp_alloc)(struct inode *inode, struct file *filp,
entry->pages = pages; entry->pages = pages;
entry->prev = NULL; entry->prev = NULL;
entry->next = dev->agp->memory; entry->next = dev->agp->memory;
if (dev->agp->memory) dev->agp->memory->prev = entry; if (dev->agp->memory)
dev->agp->memory->prev = entry;
dev->agp->memory = entry; dev->agp->memory = entry;
request.handle = entry->handle; request.handle = entry->handle;
...@@ -253,7 +257,8 @@ static drm_agp_mem_t *DRM(agp_lookup_entry)(drm_device_t *dev, ...@@ -253,7 +257,8 @@ static drm_agp_mem_t *DRM(agp_lookup_entry)(drm_device_t *dev,
drm_agp_mem_t *entry; drm_agp_mem_t *entry;
for (entry = dev->agp->memory; entry; entry = entry->next) { for (entry = dev->agp->memory; entry; entry = entry->next) {
if (entry->handle == handle) return entry; if (entry->handle == handle)
return entry;
} }
return NULL; return NULL;
} }
...@@ -279,12 +284,14 @@ int DRM(agp_unbind)(struct inode *inode, struct file *filp, ...@@ -279,12 +284,14 @@ int DRM(agp_unbind)(struct inode *inode, struct file *filp,
drm_agp_mem_t *entry; drm_agp_mem_t *entry;
int ret; int ret;
if (!dev->agp || !dev->agp->acquired) return -EINVAL; if (!dev->agp || !dev->agp->acquired)
return -EINVAL;
if (copy_from_user(&request, (drm_agp_binding_t *)arg, sizeof(request))) if (copy_from_user(&request, (drm_agp_binding_t *)arg, sizeof(request)))
return -EFAULT; return -EFAULT;
if (!(entry = DRM(agp_lookup_entry)(dev, request.handle))) if (!(entry = DRM(agp_lookup_entry)(dev, request.handle)))
return -EINVAL; return -EINVAL;
if (!entry->bound) return -EINVAL; if (!entry->bound)
return -EINVAL;
ret = DRM(unbind_agp)(entry->memory); ret = DRM(unbind_agp)(entry->memory);
if (ret == 0) if (ret == 0)
entry->bound = 0; entry->bound = 0;
...@@ -320,9 +327,11 @@ int DRM(agp_bind)(struct inode *inode, struct file *filp, ...@@ -320,9 +327,11 @@ int DRM(agp_bind)(struct inode *inode, struct file *filp,
return -EFAULT; return -EFAULT;
if (!(entry = DRM(agp_lookup_entry)(dev, request.handle))) if (!(entry = DRM(agp_lookup_entry)(dev, request.handle)))
return -EINVAL; return -EINVAL;
if (entry->bound) return -EINVAL; if (entry->bound)
return -EINVAL;
page = (request.offset + PAGE_SIZE - 1) / PAGE_SIZE; page = (request.offset + PAGE_SIZE - 1) / PAGE_SIZE;
if ((retcode = DRM(bind_agp)(entry->memory, page))) return retcode; if ((retcode = DRM(bind_agp)(entry->memory, page)))
return retcode;
entry->bound = dev->agp->base + (page << PAGE_SHIFT); entry->bound = dev->agp->base + (page << PAGE_SHIFT);
DRM_DEBUG("base = 0x%lx entry->bound = 0x%lx\n", DRM_DEBUG("base = 0x%lx entry->bound = 0x%lx\n",
dev->agp->base, entry->bound); dev->agp->base, entry->bound);
...@@ -351,16 +360,23 @@ int DRM(agp_free)(struct inode *inode, struct file *filp, ...@@ -351,16 +360,23 @@ int DRM(agp_free)(struct inode *inode, struct file *filp,
drm_agp_buffer_t request; drm_agp_buffer_t request;
drm_agp_mem_t *entry; drm_agp_mem_t *entry;
if (!dev->agp || !dev->agp->acquired) return -EINVAL; if (!dev->agp || !dev->agp->acquired)
return -EINVAL;
if (copy_from_user(&request, (drm_agp_buffer_t *)arg, sizeof(request))) if (copy_from_user(&request, (drm_agp_buffer_t *)arg, sizeof(request)))
return -EFAULT; return -EFAULT;
if (!(entry = DRM(agp_lookup_entry)(dev, request.handle))) if (!(entry = DRM(agp_lookup_entry)(dev, request.handle)))
return -EINVAL; return -EINVAL;
if (entry->bound) DRM(unbind_agp)(entry->memory); if (entry->bound)
DRM(unbind_agp)(entry->memory);
if (entry->prev)
entry->prev->next = entry->next;
else
dev->agp->memory = entry->next;
if (entry->next)
entry->next->prev = entry->prev;
if (entry->prev) entry->prev->next = entry->next;
else dev->agp->memory = entry->next;
if (entry->next) entry->next->prev = entry->prev;
DRM(free_agp)(entry->memory, entry->pages); DRM(free_agp)(entry->memory, entry->pages);
DRM(free)(entry, sizeof(*entry), DRM_MEM_AGPLISTS); DRM(free)(entry, sizeof(*entry), DRM_MEM_AGPLISTS);
return 0; return 0;
...@@ -415,14 +431,16 @@ void DRM(agp_uninit)(void) ...@@ -415,14 +431,16 @@ void DRM(agp_uninit)(void)
/** Calls drm_agp->allocate_memory() */ /** Calls drm_agp->allocate_memory() */
struct agp_memory *DRM(agp_allocate_memory)(size_t pages, u32 type) struct agp_memory *DRM(agp_allocate_memory)(size_t pages, u32 type)
{ {
if (!drm_agp->allocate_memory) return NULL; if (!drm_agp->allocate_memory)
return NULL;
return drm_agp->allocate_memory(pages, type); return drm_agp->allocate_memory(pages, type);
} }
/** Calls drm_agp->free_memory() */ /** Calls drm_agp->free_memory() */
int DRM(agp_free_memory)(struct agp_memory *handle) int DRM(agp_free_memory)(struct agp_memory *handle)
{ {
if (!handle || !drm_agp->free_memory) return 0; if (!handle || !drm_agp->free_memory)
return 0;
drm_agp->free_memory(handle); drm_agp->free_memory(handle);
return 1; return 1;
} }
...@@ -430,14 +448,16 @@ int DRM(agp_free_memory)(struct agp_memory *handle) ...@@ -430,14 +448,16 @@ int DRM(agp_free_memory)(struct agp_memory *handle)
/** Calls drm_agp->bind_memory() */ /** Calls drm_agp->bind_memory() */
int DRM(agp_bind_memory)(struct agp_memory *handle, off_t start) int DRM(agp_bind_memory)(struct agp_memory *handle, off_t start)
{ {
if (!handle || !drm_agp->bind_memory) return -EINVAL; if (!handle || !drm_agp->bind_memory)
return -EINVAL;
return drm_agp->bind_memory(handle, start); return drm_agp->bind_memory(handle, start);
} }
/** Calls drm_agp->unbind_memory() */ /** Calls drm_agp->unbind_memory() */
int DRM(agp_unbind_memory)(struct agp_memory *handle) int DRM(agp_unbind_memory)(struct agp_memory *handle)
{ {
if (!handle || !drm_agp->unbind_memory) return -EINVAL; if (!handle || !drm_agp->unbind_memory)
return -EINVAL;
return drm_agp->unbind_memory(handle); return drm_agp->unbind_memory(handle);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment