Commit c7acc688 authored by Tony Lindgren's avatar Tony Lindgren Committed by Greg Kroah-Hartman

mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode

commit 8b8a84c5 upstream.

Commit 16fa3dc7 ("mfd: omap-usb-tll: HOST TLL platform driver")
added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
bit the wrong way. The comments in the code are correct, but the inverted
use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
enabled instead of disabled unlike what the comments say.

Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
be only pinged few times before it stops responding.

Fixes: 16fa3dc7 ("mfd: omap-usb-tll: HOST TLL platform driver")
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Acked-by: default avatarRoger Quadros <rogerq@ti.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 305d63f6
...@@ -376,8 +376,8 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata) ...@@ -376,8 +376,8 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
* and use SDR Mode * and use SDR Mode
*/ */
reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
| OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
| OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE); | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
} else if (pdata->port_mode[i] == } else if (pdata->port_mode[i] ==
OMAP_EHCI_PORT_MODE_HSIC) { OMAP_EHCI_PORT_MODE_HSIC) {
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment