Commit c823f6a7 authored by Alex Dewar's avatar Alex Dewar Committed by Greg Kroah-Hartman

staging: hikey9xx: Fix incorrect assignment

In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its
default value is assigned to priv->eye_diagram_param, rather than to
priv->tx_vboost_lvl. Fix this.

Fixes: 8971a3b8 ("staging: hikey9xx: add USB physical layer for Kirin 3670")
Addresses-Coverity: CID 1497107: Incorrect expression (COPY_PASTE_ERROR)
Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
Link: https://lore.kernel.org/r/20200921212146.34662-1-alex.dewar90@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d6628e8c
...@@ -640,7 +640,7 @@ static int hi3670_phy_probe(struct platform_device *pdev) ...@@ -640,7 +640,7 @@ static int hi3670_phy_probe(struct platform_device *pdev)
if (of_property_read_u32(dev->of_node, "hisilicon,tx-vboost-lvl", if (of_property_read_u32(dev->of_node, "hisilicon,tx-vboost-lvl",
&priv->tx_vboost_lvl)) &priv->tx_vboost_lvl))
priv->eye_diagram_param = KIRIN970_USB_DEFAULT_PHY_VBOOST; priv->tx_vboost_lvl = KIRIN970_USB_DEFAULT_PHY_VBOOST;
phy = devm_phy_create(dev, NULL, &hi3670_phy_ops); phy = devm_phy_create(dev, NULL, &hi3670_phy_ops);
if (IS_ERR(phy)) if (IS_ERR(phy))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment