Commit c993df5a authored by Jens Axboe's avatar Jens Axboe

io_uring: don't double complete failed reissue request

Zorro reports that an xfstest test case is failing, and it turns out that
for the reissue path we can potentially issue a double completion on the
request for the failure path. There's an issue around the retry as well,
but for now, at least just make sure that we handle the error path
correctly.

Cc: stable@vger.kernel.org
Fixes: b63534c4 ("io_uring: re-issue block requests that failed because of resources")
Reported-by: default avatarZorro Lang <zlang@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 0abed7c6
...@@ -2578,7 +2578,6 @@ static bool io_resubmit_prep(struct io_kiocb *req, int error) ...@@ -2578,7 +2578,6 @@ static bool io_resubmit_prep(struct io_kiocb *req, int error)
} }
end_req: end_req:
req_set_fail_links(req); req_set_fail_links(req);
io_req_complete(req, ret);
return false; return false;
} }
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment