Commit ca9e4988 authored by Ajit Khaparde's avatar Ajit Khaparde Committed by David S. Miller

be2net: check for valid ether address

Allow only valid ether addresses to be assigned and used for the interface.
Signed-off-by: default avatarAjit Khaparde <ajitk@serverengines.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 35a65285
...@@ -125,6 +125,9 @@ static int be_mac_addr_set(struct net_device *netdev, void *p) ...@@ -125,6 +125,9 @@ static int be_mac_addr_set(struct net_device *netdev, void *p)
struct sockaddr *addr = p; struct sockaddr *addr = p;
int status = 0; int status = 0;
if (!is_valid_ether_addr(addr->sa_data))
return -EADDRNOTAVAIL;
status = be_cmd_pmac_del(adapter, adapter->if_handle, adapter->pmac_id); status = be_cmd_pmac_del(adapter, adapter->if_handle, adapter->pmac_id);
if (status) if (status)
return status; return status;
...@@ -2146,6 +2149,10 @@ static int be_get_config(struct be_adapter *adapter) ...@@ -2146,6 +2149,10 @@ static int be_get_config(struct be_adapter *adapter)
MAC_ADDRESS_TYPE_NETWORK, true /*permanent */, 0); MAC_ADDRESS_TYPE_NETWORK, true /*permanent */, 0);
if (status) if (status)
return status; return status;
if (!is_valid_ether_addr(mac))
return -EADDRNOTAVAIL;
memcpy(adapter->netdev->dev_addr, mac, ETH_ALEN); memcpy(adapter->netdev->dev_addr, mac, ETH_ALEN);
memcpy(adapter->netdev->perm_addr, mac, ETH_ALEN); memcpy(adapter->netdev->perm_addr, mac, ETH_ALEN);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment