Commit cc976614 authored by Masahiro Yamada's avatar Masahiro Yamada

gen_initramfs_list.sh: fix 'bad variable name' error

Prior to commit 858805b3 ("kbuild: add $(BASH) to run scripts with
bash-extension"), this shell script was almost always run by bash since
bash is usually installed on the system by default.

Now, this script is run by sh, which might be a symlink to dash. On such
distributions, the following code emits an error:

  local dev=`LC_ALL=C ls -l "${location}"`

You can reproduce the build error, for example by setting
CONFIG_INITRAMFS_SOURCE="/dev".

    GEN     usr/initramfs_data.cpio.gz
  ./usr/gen_initramfs_list.sh: 131: local: 1: bad variable name
  make[1]: *** [usr/Makefile:61: usr/initramfs_data.cpio.gz] Error 2

This is because `LC_ALL=C ls -l "${location}"` contains spaces.
Surrounding it with double-quotes fixes the error.

Fixes: 858805b3 ("kbuild: add $(BASH) to run scripts with bash-extension")
Reported-by: default avatarJory A. Pratt <anarchy@gentoo.org>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 46cf053e
...@@ -128,7 +128,7 @@ parse() { ...@@ -128,7 +128,7 @@ parse() {
str="${ftype} ${name} ${location} ${str}" str="${ftype} ${name} ${location} ${str}"
;; ;;
"nod") "nod")
local dev=`LC_ALL=C ls -l "${location}"` local dev="`LC_ALL=C ls -l "${location}"`"
local maj=`field 5 ${dev}` local maj=`field 5 ${dev}`
local min=`field 6 ${dev}` local min=`field 6 ${dev}`
maj=${maj%,} maj=${maj%,}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment