Commit cddaac04 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Arnd Bergmann

ARM: pxa/gumstix: fix attaching properties to vbus gpio device

Commit f1d6588a tried to convert GPIO lookup tables to software
properties for the vbus gpio device, bit forgot the most important
step: actually attaching the new properties to the device.

Also fix up the name of the property array to reflect the board name,
and add missing gpio/property.h and devices.h includes absence of which
causes compile failures on some configurations.

Switch "#ifdef CONFIG_USB_PXA25X" to "#if IS_ENABLED(CONFIG_USB_PXA25X)"
because it should not matter if the driver is buolt in or a module, it
still need vbus controls.
Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
Fixes: f1d6588a ("ARM: pxa/gumstix: convert vbus gpio to use software nodes")
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent e1793fea
...@@ -21,6 +21,7 @@ ...@@ -21,6 +21,7 @@
#include <linux/mtd/mtd.h> #include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h> #include <linux/mtd/partitions.h>
#include <linux/gpio/machine.h> #include <linux/gpio/machine.h>
#include <linux/gpio/property.h>
#include <linux/gpio.h> #include <linux/gpio.h>
#include <linux/err.h> #include <linux/err.h>
#include <linux/clk.h> #include <linux/clk.h>
...@@ -40,6 +41,7 @@ ...@@ -40,6 +41,7 @@
#include <linux/platform_data/mmc-pxamci.h> #include <linux/platform_data/mmc-pxamci.h>
#include "udc.h" #include "udc.h"
#include "gumstix.h" #include "gumstix.h"
#include "devices.h"
#include "generic.h" #include "generic.h"
...@@ -99,8 +101,8 @@ static void __init gumstix_mmc_init(void) ...@@ -99,8 +101,8 @@ static void __init gumstix_mmc_init(void)
} }
#endif #endif
#ifdef CONFIG_USB_PXA25X #if IS_ENABLED(CONFIG_USB_PXA25X)
static const struct property_entry spitz_mci_props[] __initconst = { static const struct property_entry gumstix_vbus_props[] __initconst = {
PROPERTY_ENTRY_GPIO("vbus-gpios", &pxa2xx_gpiochip_node, PROPERTY_ENTRY_GPIO("vbus-gpios", &pxa2xx_gpiochip_node,
GPIO_GUMSTIX_USB_GPIOn, GPIO_ACTIVE_HIGH), GPIO_GUMSTIX_USB_GPIOn, GPIO_ACTIVE_HIGH),
PROPERTY_ENTRY_GPIO("pullup-gpios", &pxa2xx_gpiochip_node, PROPERTY_ENTRY_GPIO("pullup-gpios", &pxa2xx_gpiochip_node,
...@@ -111,6 +113,7 @@ static const struct property_entry spitz_mci_props[] __initconst = { ...@@ -111,6 +113,7 @@ static const struct property_entry spitz_mci_props[] __initconst = {
static const struct platform_device_info gumstix_gpio_vbus_info __initconst = { static const struct platform_device_info gumstix_gpio_vbus_info __initconst = {
.name = "gpio-vbus", .name = "gpio-vbus",
.id = PLATFORM_DEVID_NONE, .id = PLATFORM_DEVID_NONE,
.properties = gumstix_vbus_props,
}; };
static void __init gumstix_udc_init(void) static void __init gumstix_udc_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment